Update session cookie name due to upcoming server change

[cy245]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @cy245, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request prepares the client-side application for an upcoming server change by updating the name of the session cookie. The modification involves adding a __Secure- prefix to the SESSION_ID_KEY constant, which is a standard practice to enforce secure cookie transmission over HTTPS. This ensures continued secure authentication and compatibility with the new server configuration.

Highlights

• Session Cookie Name Update: The SESSION_ID_KEY constant has been updated across the application to include the __Secure- prefix, aligning with an upcoming server change.
• Enhanced Security: The change to __Secure-SESAME_SESSION_COOKIE= ensures that the session cookie will only be transmitted over secure (HTTPS) connections, bolstering security.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the session cookie name in both the app and wear modules to align with an upcoming server change. The change is applied correctly. However, this highlights an opportunity to improve maintainability. The SESSION_ID_KEY constant is duplicated in both modules. I've added a comment suggesting the creation of a shared module to define this constant in a single place, following the DRY (Don't Repeat Yourself) principle. This would prevent potential inconsistencies and make future updates easier.

[gemini-code-assist]

This constant SESSION_ID_KEY is also defined in Shrine/wear/src/main/java/com/authentication/shrinewear/network/AuthNetworkClient.kt. Duplicating constants across different modules can lead to maintenance issues and inconsistencies. If this value needs to be updated in the future, it must be changed in multiple places, which is error-prone.

To improve this, consider creating a shared Gradle module (e.g., :common or :core) that both the :app and :wear modules can depend on. You could then define SESSION_ID_KEY once in this shared module and use it across the project. This adheres to the Don't Repeat Yourself (DRY) principle and improves long-term maintainability.