Skip to content

Commit fa48895

Browse files
icbakercopybara-github
authored andcommitted
Fix Gradle-only failure in MkvPlaybackTest with muxed subrip subs
This ensures that the subtitles are fully loaded and parsed before playback starts. This failure was flagged in #2628 (comment) PiperOrigin-RevId: 787143300
1 parent d011c27 commit fa48895

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

libraries/exoplayer/src/test/java/androidx/media3/exoplayer/e2etest/MkvPlaybackTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package androidx.media3.exoplayer.e2etest;
1717

18+
import static androidx.media3.test.utils.robolectric.TestPlayerRunHelper.advance;
1819
import static org.robolectric.annotation.GraphicsMode.Mode.NATIVE;
1920

2021
import android.content.Context;
@@ -29,7 +30,6 @@
2930
import androidx.media3.test.utils.FakeClock;
3031
import androidx.media3.test.utils.robolectric.PlaybackOutput;
3132
import androidx.media3.test.utils.robolectric.ShadowMediaCodecConfig;
32-
import androidx.media3.test.utils.robolectric.TestPlayerRunHelper;
3333
import androidx.test.core.app.ApplicationProvider;
3434
import com.google.common.collect.ImmutableList;
3535
import org.junit.Rule;
@@ -83,8 +83,9 @@ public void test() throws Exception {
8383

8484
player.setMediaItem(MediaItem.fromUri("asset:///media/mkv/" + inputFile));
8585
player.prepare();
86+
advance(player).untilFullyBuffered();
8687
player.play();
87-
TestPlayerRunHelper.runUntilPlaybackState(player, Player.STATE_ENDED);
88+
advance(player).untilState(Player.STATE_ENDED);
8889
player.release();
8990
surface.release();
9091

0 commit comments

Comments
 (0)