-
Notifications
You must be signed in to change notification settings - Fork 29
Remove window.location.hash parsing code #282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sir @tdhock I found that
Please advise before I proceed. |
|
please remove test |
The URL fragment test is no longer needed since the window.location.hash parsing feature has been removed. @tdhock feedback I took before doing it
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #282 +/- ##
==========================================
+ Coverage 72.77% 73.06% +0.28%
==========================================
Files 164 164
Lines 8805 8758 -47
==========================================
- Hits 6408 6399 -9
+ Misses 2397 2359 -38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
also please add NEWS item |
|
thanks |
Fixes #280
Problem
Old code in animint.js tries to parse all URL hash fragments as animint selector format (#variable={value}), but R Markdown creates simple anchors like #section-1 for headings. This causes JavaScript errors.
Changes
##Test
Status