Skip to content

Commit 6c7c731

Browse files
annevkannevk
committed
Enhanced <select>: HTML parser changes
https://bugs.webkit.org/show_bug.cgi?id=299959 rdar://140875257 Reviewed by Ryosuke Niwa. This implements the parser aspects of whatwg/html#10548 behind a flag. The old code path continues to be tested through our legacy HTML parser test suite. This does not yet implement new logic for the <select>, <optgroup>, <option>, and <hr> classes to account for the fact that <optgroup>, <option>, and <hr> can now appear as descendants and as such this is only useful for testing. Remove fast/parser/input-textarea-inside-select-element.html test as it was duplicative of both the legacy HTML parser test suite and WPT coverage. (Until these recent <select> changes were made the legacy HTML parser test suite was synchronized with the WPT test suite. We'll remove it once it's easier to add HTML parser tests on the WPT side.) Canonical link: https://commits.webkit.org/300998@main
1 parent ab97aab commit 6c7c731

File tree

43 files changed

+215
-1858
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+215
-1858
lines changed

‎LayoutTests/fast/forms/textarea-placeholder-relayout-assertion-expected.txt‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
PASS if not crashed.
22

33
>
4-
000000AA00A000A0A0A00A0000A0A00AAAAAA00AAAAAAA0A0AA00A00A000A0AA000AA0

‎LayoutTests/fast/parser/input-textarea-inside-select-element-expected.txt‎

Lines changed: 0 additions & 9 deletions
This file was deleted.

‎LayoutTests/fast/parser/input-textarea-inside-select-element.html‎

Lines changed: 0 additions & 18 deletions
This file was deleted.

‎LayoutTests/html5lib/generated/run-tests1-data.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!DOCTYPE html>
1+
<!DOCTYPE html><!-- webkit-test-runner [ HTMLEnhancedSelectParsingEnabled=false ] -->
22
<script>
33
var test_files = [ '../resources/tests1.dat' ]
44
</script>

‎LayoutTests/html5lib/generated/run-tests1-write.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!DOCTYPE html>
1+
<!DOCTYPE html><!-- webkit-test-runner [ HTMLEnhancedSelectParsingEnabled=false ] -->
22
<script>
33
var test_files = [ '../resources/tests1.dat' ]
44
</script>

‎LayoutTests/html5lib/generated/run-tests10-data.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!DOCTYPE html>
1+
<!DOCTYPE html><!-- webkit-test-runner [ HTMLEnhancedSelectParsingEnabled=false ] -->
22
<script>
33
var test_files = [ '../resources/tests10.dat' ]
44
</script>

‎LayoutTests/html5lib/generated/run-tests10-write.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!DOCTYPE html>
1+
<!DOCTYPE html><!-- webkit-test-runner [ HTMLEnhancedSelectParsingEnabled=false ] -->
22
<script>
33
var test_files = [ '../resources/tests10.dat' ]
44
</script>

‎LayoutTests/html5lib/generated/run-tests7-data.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!DOCTYPE html>
1+
<!DOCTYPE html><!-- webkit-test-runner [ HTMLEnhancedSelectParsingEnabled=false ] -->
22
<script>
33
var test_files = [ '../resources/tests7.dat' ]
44
</script>

‎LayoutTests/html5lib/generated/run-tests7-write.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!DOCTYPE html>
1+
<!DOCTYPE html><!-- webkit-test-runner [ HTMLEnhancedSelectParsingEnabled=false ] -->
22
<script>
33
var test_files = [ '../resources/tests7.dat' ]
44
</script>

‎LayoutTests/html5lib/generated/run-tests9-data.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<!DOCTYPE html>
1+
<!DOCTYPE html><!-- webkit-test-runner [ HTMLEnhancedSelectParsingEnabled=false ] -->
22
<script>
33
var test_files = [ '../resources/tests9.dat' ]
44
</script>

0 commit comments

Comments
 (0)