[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Author: pre-commit-ci[bot]

README.md

@@ -5,10 +5,8 @@ This repository contains the `ansible.scm` Ansible Collection that allows you to
 <!--start requires_ansible-->
 ## Ansible version compatibility
 
-This collection has been tested against following Ansible versions: **>=2.15.0**.
+This collection has been tested against the following Ansible versions: **>=2.15.0**.
 
-For collections that support Ansible 2.9, please ensure you update your `network_os` to use the
-fully qualified collection name (for example, `cisco.ios.ios`).
 Plugins and modules within a collection may be tested with only specific Ansible versions.
 A collection may contain metadata that identifies these versions.
 PEP440 is the schema used to describe the versions of Ansible.

plugins/action/git_publish.py

@@ -57,7 +57,7 @@ class ActionModule(GitBase):
 
     # pylint: disable=too-many-arguments
     def __init__(  # noqa: PLR0913
-        self: T,
+        self,
         connection: Connection,
         loader: DataLoader,
         play_context: PlayContext,
@@ -91,7 +91,7 @@ def __init__(  # noqa: PLR0913
         self._supports_async = True
         self._result: Result = Result()
 
-    def _check_argspec(self: T) -> None:
+    def _check_argspec(self) -> None:
         """Check the argspec for the action plugin.
 
         :raises AnsibleActionFail: If the argspec is invalid
@@ -108,7 +108,7 @@ def _check_argspec(self: T) -> None:
             err = "Token can not be an empty string"
             raise AnsibleActionFail(err)
 
-    def _configure_git_user_name(self: T) -> None:
+    def _configure_git_user_name(self) -> None:
         """Configure the git user name."""
         command_parts = list(self._base_command)
         command_parts.extend(["config", "--get", "user.name"])
@@ -131,7 +131,7 @@ def _configure_git_user_name(self: T) -> None:
         self._run_command(command=command)
         self._result.user_name = name
 
-    def _configure_git_user_email(self: T) -> None:
+    def _configure_git_user_email(self) -> None:
         """Configure the git user email."""
         command_parts = list(self._base_command)
         command_parts.extend(["config", "--get", "user.email"])
@@ -154,7 +154,7 @@ def _configure_git_user_email(self: T) -> None:
         self._run_command(command=command)
         self._result.user_email = email
 
-    def _add(self: T) -> None:
+    def _add(self) -> None:
         """Add files for the pending commit."""
         command_parts = list(self._base_command)
         files = " ".join(self._task.args["include"])
@@ -165,7 +165,7 @@ def _add(self: T) -> None:
         )
         self._run_command(command=command)
 
-    def _commit(self: T) -> None:
+    def _commit(self) -> None:
         """Perform a commit for the pending push."""
         command_parts = list(self._base_command)
         message = self._task.args["commit"]["message"].format(play_name=self._play_name)
@@ -177,7 +177,7 @@ def _commit(self: T) -> None:
         )
         self._run_command(command=command)
 
-    def _tag(self: T) -> None:
+    def _tag(self) -> None:
         """Create a tag object."""
         command_parts = list(self._base_command)
         message = self._task.args["tag"].get("message")
@@ -192,7 +192,7 @@ def _tag(self: T) -> None:
         )
         self._run_command(command=command)
 
-    def _push(self: T) -> None:
+    def _push(self) -> None:
         """Push the commit to the origin."""
         command_parts = list(self._base_command)
         command_parts.extend(["remote", "-v"])
@@ -235,7 +235,7 @@ def _push(self: T) -> None:
                 line for line in command.stderr.split("remote:") if "https" in line
             ).strip()
 
-    def _remove_repo(self: T) -> None:
+    def _remove_repo(self) -> None:
         """Remove the temporary directory."""
         if not self._task.args["remove"]:
             return
@@ -247,7 +247,7 @@ def _remove_repo(self: T) -> None:
             self._result.msg = "Failed to remove repository"
 
     def run(
-        self: T,
+        self,
         tmp: None = None,
         task_vars: Optional[Dict[str, JSONTypes]] = None,
     ) -> Dict[str, JSONTypes]:

plugins/action/git_retrieve.py

@@ -61,7 +61,7 @@ class ActionModule(GitBase):
     _requires_connection = False
 
     def __init__(  # noqa: PLR0913
-        self: T,
+        self,
         connection: Connection,
         loader: DataLoader,
         play_context: PlayContext,
@@ -98,7 +98,7 @@ def __init__(  # noqa: PLR0913
         self._supports_async = True
         self._result: Result = Result()
 
-    def _check_argspec(self: T) -> None:
+    def _check_argspec(self) -> None:
         """Check the argspec for the action plugin.
 
         :raises AnsibleActionFail: If the argspec is invalid
@@ -120,14 +120,14 @@ def _check_argspec(self: T) -> None:
             raise AnsibleActionFail(err)
 
     @property
-    def _branch_exists(self: T) -> bool:
+    def _branch_exists(self) -> bool:
         """Return True if the branch exists.
 
         :returns: True if the branch exists
         """
         return self._branch_name in self._branches
 
-    def _host_key_checking(self: T) -> None:
+    def _host_key_checking(self) -> None:
         """Configure host key checking."""
         origin = self._task.args["origin"]["url"]
         upstream = self._task.args["upstream"].get("url") or ""
@@ -151,7 +151,7 @@ def _host_key_checking(self: T) -> None:
         )
         self._run_command(command=command)
 
-    def _clone(self: T) -> None:
+    def _clone(self) -> None:
         """Clone the repository.
 
         Additionally set the base command to the repository path.
@@ -209,7 +209,7 @@ def _clone(self: T) -> None:
         self._base_command = ("git", "-C", self._repo_path)
         return
 
-    def _get_branches(self: T) -> None:
+    def _get_branches(self) -> None:
         """Get the branches."""
         command_parts = list(self._base_command)
         command_parts.extend(["branch", "-a"])
@@ -256,14 +256,14 @@ def _get_branches(self: T) -> None:
         self._result.branch_name = self._branch_name
         return
 
-    def _detect_duplicate_branch(self: T) -> None:
+    def _detect_duplicate_branch(self) -> None:
         """Detect duplicate branch."""
         duplicate_detection = self._task.args["branch"]["duplicate_detection"]
         if duplicate_detection and self._branch_exists:
             self._result.failed = True
             self._result.msg = f"Branch '{self._branch_name}' already exists"
 
-    def _switch_checkout(self: T) -> None:
+    def _switch_checkout(self) -> None:
         """Switch to or checkout the branch."""
         command_parts = list(self._base_command)
         branch = self._branch_name
@@ -283,7 +283,7 @@ def _switch_checkout(self: T) -> None:
         )
         self._run_command(command=command)
 
-    def _add_upstream_remote(self: T) -> None:
+    def _add_upstream_remote(self) -> None:
         """Add the upstream remote."""
         if not self._task.args["upstream"].get("url"):
             return
@@ -298,7 +298,7 @@ def _add_upstream_remote(self: T) -> None:
         self._run_command(command=command)
         return
 
-    def _pull_upstream(self: T) -> None:
+    def _pull_upstream(self) -> None:
         """Pull from upstream."""
         if not self._task.args["upstream"].get("url"):
             return
@@ -325,7 +325,7 @@ def _pull_upstream(self: T) -> None:
         return
 
     def run(
-        self: T,
+        self,
         tmp: None = None,
         task_vars: Optional[Dict[str, JSONTypes]] = None,
     ) -> Dict[str, JSONTypes]:

plugins/plugin_utils/command.py

@@ -39,15 +39,15 @@ class Command:
     stderr_lines: List[str] = field(default_factory=list)
 
     @property
-    def command(self: T) -> str:
+    def command(self) -> str:
         """Return the command as a string.
 
         :return: The command as a string.
         """
         return shlex.join(self.command_parts)
 
     @property
-    def cleaned(self: T) -> Dict[str, Union[int, Dict[str, str], List[str], str]]:
+    def cleaned(self) -> Dict[str, Union[int, Dict[str, str], List[str], str]]:
         """Return the sanitized details of the command for the log.
 
         :return: The sanitized details of the command for the log.

plugins/plugin_utils/git_base.py

@@ -44,7 +44,7 @@ class ActionInit:
 
     @property
     def asdict(
-        self: T,
+        self,
     ) -> Dict[str, Union[Connection, DataLoader, PlayContext, ModuleType, Task, Templar]]:
         """Create a dictionary, avoiding the deepcopy with dataclass.asdict.
 
@@ -71,7 +71,7 @@ class ResultBase:  # pylint: disable=too-many-instance-attributes
 class GitBase(ActionBase):  # type: ignore[misc] # parent has type Any
     """Base class for the git paction plugins."""
 
-    def __init__(self: U, action_init: ActionInit) -> None:
+    def __init__(self, action_init: ActionInit) -> None:
         """Initialize the action plugin.
 
         :param action_init: The keyword arguments for action base
@@ -97,7 +97,7 @@ def _git_auth_header(token: str) -> Tuple[str, List[str]]:
         ]
         return basic_encoded, cli_parameters
 
-    def _run_command(self: U, command: Command, ignore_errors: bool = False) -> None:
+    def _run_command(self, command: Command, ignore_errors: bool = False) -> None:
         """Run a command and append the command result to the results.
 
         :param command: The command to run

tests/unit/conftest.py

@@ -20,7 +20,7 @@
 from .definitions import ActionModuleInit
 
 
-@pytest.fixture()
+@pytest.fixture
 def action_init() -> ActionModuleInit:
     """Provide a fixture for action initialization.