Skip to content

Conversation

@Devin-Crawford
Copy link
Contributor

Use the project name to save the new project after it is extracted from an archive.

Description

When an archive is opened, the default file name for the project should be the same as that of the archive root file name.

Issue linked

Resolve #6400

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

Use the project name to save the new project after it is extracted from an archive.
@Devin-Crawford Devin-Crawford requested a review from a team as a code owner July 14, 2025 09:04
@Devin-Crawford Devin-Crawford linked an issue Jul 14, 2025 that may be closed by this pull request
2 tasks
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the bug Something isn't working label Jul 14, 2025
@Devin-Crawford Devin-Crawford marked this pull request as draft July 14, 2025 09:21
Devin-Crawford and others added 8 commits July 17, 2025 07:09
- When an archive file is extracted, the
  project file stem name will be incremented
  by an integer if the project file already
  exists.
- Simplify syntax.
…oject' into fix/6400-use-archive-name-for-project
# Conflicts:
#	src/ansys/aedt/core/application/design.py
- Check that archive file is saved and opend correctly.
- Improve support for Path
@github-actions github-actions bot added the testing Anything related to testing label Aug 12, 2025
Devin-Crawford and others added 5 commits August 12, 2025 14:44
- Fix test_01_Design.py
- Fix test_01_Design.py so each unit test runs standalone.
- Make all tests independent #6523
- Deprecate Design.rename_design()
@Devin-Crawford Devin-Crawford marked this pull request as ready for review August 13, 2025 09:30
@Devin-Crawford Devin-Crawford enabled auto-merge (squash) August 18, 2025 12:14
@Devin-Crawford Devin-Crawford marked this pull request as draft August 18, 2025 12:16
auto-merge was automatically disabled August 18, 2025 12:16

Pull request was converted to draft

@Devin-Crawford Devin-Crawford changed the title Update archive project name REFACTOR: Update archive project name Aug 18, 2025
@Devin-Crawford Devin-Crawford marked this pull request as ready for review August 18, 2025 12:47
@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 79.59184% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.76%. Comparing base (fea45cf) to head (78f9088).
⚠️ Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (79.59%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6401       +/-   ##
===========================================
- Coverage   81.93%   48.76%   -33.17%     
===========================================
  Files         236      236               
  Lines       75770    75779        +9     
===========================================
- Hits        62083    36957    -25126     
- Misses      13687    38822    +25135     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Devin-Crawford
Copy link
Contributor Author

Branch is corrupted. Need to fix it.

@Devin-Crawford Devin-Crawford deleted the fix/6400-use-archive-name-for-project branch August 18, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to specify project name when opening an archive

3 participants