From a6801df37b69370daa6e26e81aba81e9bb0af1c2 Mon Sep 17 00:00:00 2001 From: Xiangpeng Hao Date: Sun, 29 Jun 2025 13:22:49 -0500 Subject: [PATCH 1/2] make builder pub --- parquet/src/arrow/array_reader/builder.rs | 4 ++-- parquet/src/arrow/array_reader/mod.rs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/parquet/src/arrow/array_reader/builder.rs b/parquet/src/arrow/array_reader/builder.rs index 14a475859810..6dcf05ccf8ad 100644 --- a/parquet/src/arrow/array_reader/builder.rs +++ b/parquet/src/arrow/array_reader/builder.rs @@ -35,12 +35,12 @@ use crate::errors::{ParquetError, Result}; use crate::schema::types::{ColumnDescriptor, ColumnPath, Type}; /// Builds [`ArrayReader`]s from parquet schema, projection mask, and RowGroups reader -pub(crate) struct ArrayReaderBuilder<'a> { +pub struct ArrayReaderBuilder<'a> { row_groups: &'a dyn RowGroups, } impl<'a> ArrayReaderBuilder<'a> { - pub(crate) fn new(row_groups: &'a dyn RowGroups) -> Self { + pub fn new(row_groups: &'a dyn RowGroups) -> Self { Self { row_groups } } diff --git a/parquet/src/arrow/array_reader/mod.rs b/parquet/src/arrow/array_reader/mod.rs index 94d61c9eacf5..10d0eab7aa71 100644 --- a/parquet/src/arrow/array_reader/mod.rs +++ b/parquet/src/arrow/array_reader/mod.rs @@ -45,7 +45,7 @@ mod struct_array; #[cfg(test)] mod test_util; -pub(crate) use builder::ArrayReaderBuilder; +pub use builder::ArrayReaderBuilder; pub use byte_array::make_byte_array_reader; pub use byte_array_dictionary::make_byte_array_dictionary_reader; #[allow(unused_imports)] // Only used for benchmarks From e57c5bc21a8a67fc03423590ad8374d47b8e458b Mon Sep 17 00:00:00 2001 From: Xiangpeng Hao Date: Sun, 29 Jun 2025 13:27:14 -0500 Subject: [PATCH 2/2] add a comment --- parquet/src/arrow/array_reader/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/parquet/src/arrow/array_reader/mod.rs b/parquet/src/arrow/array_reader/mod.rs index 10d0eab7aa71..ec461a7cccb1 100644 --- a/parquet/src/arrow/array_reader/mod.rs +++ b/parquet/src/arrow/array_reader/mod.rs @@ -45,6 +45,7 @@ mod struct_array; #[cfg(test)] mod test_util; +// Note that this crate is public under the `experimental` feature flag. pub use builder::ArrayReaderBuilder; pub use byte_array::make_byte_array_reader; pub use byte_array_dictionary::make_byte_array_dictionary_reader;