Skip to content

Commit 993ef83

Browse files
branch-4.0: [fix](recycler) Avoiding Null Pointer Dereference When Calling check_meta #56653 (#56775)
Cherry-picked from #56653 Co-authored-by: Yixuan Wang <[email protected]>
1 parent 2a6b21e commit 993ef83

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cloud/src/recycler/recycler_service.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -656,10 +656,6 @@ void RecyclerServiceImpl::http(::google::protobuf::RpcController* controller,
656656
auto port = uri.GetQuery("port");
657657
auto user = uri.GetQuery("user");
658658
auto password = uri.GetQuery("password");
659-
LOG(INFO) << " host " << *host;
660-
LOG(INFO) << " port " << *port;
661-
LOG(INFO) << " user " << *user;
662-
LOG(INFO) << " instance " << *instance_id;
663659
if (instance_id == nullptr || instance_id->empty() || host == nullptr || host->empty() ||
664660
port == nullptr || port->empty() || password == nullptr || user == nullptr ||
665661
user->empty()) {
@@ -668,6 +664,10 @@ void RecyclerServiceImpl::http(::google::protobuf::RpcController* controller,
668664
status_code = 400;
669665
return;
670666
}
667+
LOG(INFO) << " host " << *host;
668+
LOG(INFO) << " port " << *port;
669+
LOG(INFO) << " user " << *user;
670+
LOG(INFO) << " instance " << *instance_id;
671671
check_meta(txn_kv_, *instance_id, *host, *port, *user, *password, msg);
672672
status_code = 200;
673673
response_body = msg;

0 commit comments

Comments
 (0)