Skip to content

[fix](recycler) Avoiding Null Pointer Dereference When Calling check_meta #56653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Oct 10, 2025
Merged

[fix](recycler) Avoiding Null Pointer Dereference When Calling check_meta #56653

dataroaring merged 1 commit into from
Oct 10, 2025

Conversation

@wyxxxcat
Copy link
Contributor

@wyxxxcat wyxxxcat commented Sep 30, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
Copy link
Contributor Author

wyxxxcat commented Sep 30, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 30, 2025

Cloud UT Coverage Report

Increment line coverage 0.00% (0/4) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.35% (1632/1958)
Line Coverage 67.88% (28841/42488)
Region Coverage 68.11% (14218/20876)
Branch Coverage 58.42% (7571/12960)

dataroaring
dataroaring approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 1ddd2a7 into apache:master Oct 10, 2025
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 10, 2025
@wyxxxcat
[fix](recycler) Avoiding Null Pointer Dereference When Calling check_…
3db4045 
…meta (#56653)
@github-actions github-actions bot mentioned this pull request Oct 10, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Oct 10, 2025
@wyxxxcat
[fix](recycler) Avoiding Null Pointer Dereference When Calling check_…
654d543 
…meta (#56653)
@github-actions github-actions bot mentioned this pull request Oct 10, 2025
Merged
morrySnow pushed a commit that referenced this pull request Oct 11, 2025
@github-actions @wyxxxcat
branch-3.1: [fix](recycler) Avoiding Null Pointer Dereference When Ca…
2fbdd90 
…lling check_meta #56653 (#56773)

Cherry-picked from #56653

Co-authored-by: Yixuan Wang <[email protected]>
yiguolei pushed a commit that referenced this pull request Oct 11, 2025
@github-actions @wyxxxcat
branch-4.0: [fix](recycler) Avoiding Null Pointer Dereference When Ca…
993ef83 
…lling check_meta #56653 (#56775)

Cherry-picked from #56653

Co-authored-by: Yixuan Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@koarz koarz koarz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.2-merged dev/4.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wyxxxcat @hello-stephen @koarz @dataroaring @yiguolei @morrySnow