fix

Author: lihaosky

flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/ModelTypeUtils.java

@@ -118,9 +118,8 @@ private static Optional<List<DataType>> inferMLPredictInputTypes(
             return Optional.empty();
         }
 
-        // TODO: validate config map
-        // Optional<Map> map = callContext.getArgumentValue(3, Map.class);
-
+        // Config map validation is done in StreamPhysicalMLPredictTableFunctionRule since
+        // we are not able to get map literal here.
         return Optional.of(callContext.getArgumentDataTypes());
     }
 

flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/SystemTypeInference.java

@@ -544,7 +544,6 @@ public Optional<List<DataType>> inferInputTypes(
             try {
                 checkTableArgs(staticArgs, callContext);
                 if (allowSystemArgs) {
-                    // Check that the static arguments are valid
                     checkUidArg(callContext);
                 }
             } catch (ValidationException e) {

flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/inference/InputTypeStrategiesTestBase.java

@@ -58,12 +58,6 @@ public abstract class InputTypeStrategiesTestBase {
     @ParameterizedTest(name = "{index}: {0}")
     @MethodSource("testData")
     void testStrategy(TestSpec testSpec) {
-        /*
-        if (!testSpec.description.contains("Descriptor column not found in table")
-                && !testSpec.description.contains("Descriptor column count")) {
-            return;
-        }
-         */
         if (testSpec.expectedSignature != null) {
             assertThat(generateSignature(testSpec)).isEqualTo(testSpec.expectedSignature);
         }

flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/QueryOperationConverter.java

@@ -344,9 +344,6 @@ public RelNode visit(FunctionQueryOperation functionTable) {
             // relBuilder.build() works in LIFO fashion, this restores the original input order
             Collections.reverse(inputStack);
 
-            // TODO: should we check if contextFunction is builtin ml_predict and use
-            // SqlPredictFunction instead of BridgingSqlFunction? PTF BridgeSqlFunction will be
-            // handled by StreamPhysicalProcessTableFunctionRule which won't work for ml_predict
             final BridgingSqlFunction sqlFunction =
                     BridgingSqlFunction.of(relBuilder.getCluster(), contextFunction);