Skip to content

test: make hive.store.TestHiveStore.testAutoCreateSchema deterministic #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: make hive.store.TestHiveStore.testAutoCreateSchema deterministic #298

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion gora-hive/src/test/java/org/apache/gora/hive/store/TestHiveStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.nio.charset.Charset;
import java.util.ArrayList;
import java.util.Set;
import java.util.concurrent.TimeUnit;
import org.apache.avro.util.Utf8;
import org.apache.gora.examples.generated.Employee;
import org.apache.gora.examples.generated.Metadata;
Expand Down Expand Up @@ -53,7 +54,35 @@ public class TestHiveStore extends DataStoreTestBase {

@Override
public void assertSchemaExists(String schemaName) throws Exception {
assertTrue(employeeStore.schemaExists());
if ("Employee".equals(schemaName)) {
assertTrue(employeeStore.schemaExists());
return;
}
// Include WebPage because base tests call assertSchemaExists("WebPage") in DataStoreTestBase#testTruncateSchema.
if ("WebPage".equals(schemaName)) {
assertTrue(webPageStore.schemaExists());
return;
}
throw new AssertionError("unsupported schema name: " + schemaName);
}

@Override
public void assertAutoCreateSchema() throws Exception {
// Poll briefly for Hive metastore visibility only in the auto-create scenario.
final long timeoutNanos = TimeUnit.SECONDS.toNanos(5);
final long sleepMillis = 100L;
long deadline = System.nanoTime() + timeoutNanos;
employeeStore.flush();
while (System.nanoTime() < deadline) {
if (employeeStore.schemaExists()) {
assertSchemaExists(((HiveStore<String, Employee>) employeeStore).getSchemaName());
return;
}
TimeUnit.MILLISECONDS.sleep(sleepMillis);
employeeStore.flush();
}
// If still not visible by timeout, fail via the original assertion.
assertSchemaExists(((HiveStore<String, Employee>) employeeStore).getSchemaName());
}

@Override
Expand Down
Loading