test: make hivestore result size checks deterministic #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
assertResultSizeas the Hive-tailored counterpart toDataStoreTestUtil.testResultSizeRoot Cause
Result-size checks relied on immediate schema visibility and deterministic iteration. Hive may expose newly written rows with a delay, yielding divergent counts when the generic helper runs without the additional synchronization provided in other deterministic branches.
Fix
awaitWebPageSchema,populateWebPages, andsortedWebPageUrlsso every query operates on a confirmed schema and stable key orderingassertResultSizeby mirroring the core logic ofDataStoreTestUtil.testResultSize(...), while adding Hive-specific guarding against duplicate or missing rowsThis change is constrained to test-only sources; production code remains untouched.
Validation
edu.illinois:nondex-maven-plugin:2.1.7reports no discrepanciesAdditional Notes
assertResultSizepreserves the loop structure and expectations fromDataStoreTestUtil.testResultSize(...), adding only the visibility waits and set-based checks required for Hive. The helper functions introduced here are consistent with earlier deterministic fixes for the same class.