-
Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-17861. improve YARN Registry DNS Server qps #8106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eubnara
wants to merge
1
commit into
apache:trunk
Choose a base branch
from
eubnara:HADOOP-17861
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+115
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eubnara
commented
Nov 27, 2025
| if (response.length > output.capacity()) { | ||
| LOG.warn("{}: Response of UDP query {} exceeds limit {}", | ||
| remoteAddress, query.getQuestion(), output.limit()); | ||
| query.getHeader().setFlag(Flags.TC); |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the response of UDP query exceeds limit, TC(truncated) flag should be set in order for the client to request again with TCP query.
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
There are some points to improve the performance of YARN Registry DNS Server.
In our environment, QPS of original yarn dns server is about 5000 (UDP), 100 (TCP).
Now, QPS of our improved yarn dns server is about 47000 (UDP), 500 (TCP).
I will make a pull request at https://github.com/apache/hadoop soon.
How was this patch tested?
Our team members have tested this manually in our cluster.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?