Change break to continue

tomasbanet · tomasbanet · commit e81eeac70857 · 2025-08-27T15:23:23.000+01:00
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/SerialReplicationSourceWALReader.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/SerialReplicationSourceWALReader.java
@@ -96,11 +96,11 @@ protected void readWALEntries(WALEntryStream entryStream, WALEntryBatch batch)
             break;
           }
           sleepMultiplier = sleep(sleepMultiplier);
-          // Always make sure to break after handling the exception.
+          // Always make sure to continue/break from the loop after handling the exception.
           // Otherwise we will drop down below into logic to push the entry,
           // but since we don't know if the entry can be pushed we may push
           // the entry out of order, breaking serial replication guarantees.
-          break;
+          continue;
         }
         // arrive here means we can push the entry, record the last sequence id
         batch.setLastSeqId(Bytes.toString(entry.getKey().getEncodedRegionName()),

Original file line number	Diff line number	Diff line change
`@@ -96,11 +96,11 @@ protected void readWALEntries(WALEntryStream entryStream, WALEntryBatch batch)`
`96`	`96`	`break;`
`97`	`97`	`}`
`98`	`98`	`sleepMultiplier = sleep(sleepMultiplier);`
`99`		`- // Always make sure to break after handling the exception.`
	`99`	`+ // Always make sure to continue/break from the loop after handling the exception.`
`100`	`100`	`// Otherwise we will drop down below into logic to push the entry,`
`101`	`101`	`// but since we don't know if the entry can be pushed we may push`
`102`	`102`	`// the entry out of order, breaking serial replication guarantees.`
`103`		`- break;`
	`103`	`+ continue;`
`104`	`104`	`}`
`105`	`105`	`// arrive here means we can push the entry, record the last sequence id`
`106`	`106`	`batch.setLastSeqId(Bytes.toString(entry.getKey().getEncodedRegionName()),`