HIVE-28691: Check if the path exists before deleting in FileUtils#moveToTrash (#5596)(Wechar Yu, reviewed by Denys Kuzmenko, Butao Zhang)

Author: wecharyu

standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java

@@ -17,7 +17,6 @@
  */
 package org.apache.hadoop.hive.metastore.utils;
 
-import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.net.URI;
 import java.util.ArrayList;
@@ -85,7 +84,11 @@ public static boolean moveToTrash(FileSystem fs, Path f, Configuration conf, boo
     LOG.debug("deleting  " + f);
     boolean result;
     try {
-      if(purge) {
+      if (!fs.exists(f)) {
+        LOG.warn("The path to moveToTrash does not exist: " + f);
+        return true;
+      }
+      if (purge) {
         LOG.debug("purge is set to true. Not moving to Trash " + f);
       } else {
         result = Trash.moveToAppropriateTrash(fs, f, conf);

standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreFsImpl.java

@@ -18,8 +18,6 @@
 
 package org.apache.hadoop.hive.metastore;
 
-import java.io.FileNotFoundException;
-
 import org.apache.hadoop.hive.metastore.utils.FileUtils;
 import org.apache.hadoop.hive.metastore.utils.MetaStoreUtils;
 import org.slf4j.Logger;
@@ -41,15 +39,9 @@ public boolean deleteDir(FileSystem fs, Path f, boolean recursive,
       if (FileUtils.moveToTrash(fs, f, conf, ifPurge)) {
         return true;
       }
-      if (fs.exists(f)) {
-        throw new MetaException("Unable to delete directory: " + f);
-      }
-      return true;
-    } catch (FileNotFoundException e) {
-      return true; // ok even if there is not data
     } catch (Exception e) {
       MetaStoreUtils.throwMetaException(e);
     }
-    return false;
+    throw new MetaException("Unable to delete directory: " + f);
   }
 }