add test for not exist file

Author: wecharyu

standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/Warehouse.java

@@ -512,7 +512,8 @@ public boolean isWritable(Path path) {
       return false;
     }
     try {
-      HdfsUtils.checkFileAccess(path, conf, FsAction.WRITE);
+      FileSystem fs = getFs(path);
+      HdfsUtils.checkFileAccess(fs, path, FsAction.WRITE);
       return true;
     } catch (FileNotFoundException fnfe){
       // File named by path doesn't exist; nothing to validate.

standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/HdfsUtils.java

@@ -63,14 +63,13 @@ public class HdfsUtils {
 
   /**
    * Check the permissions on a file.
+   * @param fs Filesystem the file is contained in
    * @param path the file path
-   * @param conf the {@link Configuration} used when checking permissions
    * @param action action to be performed
    * @throws IOException If thrown by Hadoop
    */
-  public static void checkFileAccess(Path path, Configuration conf, FsAction action)
+  public static void checkFileAccess(FileSystem fs, Path path, FsAction action)
       throws IOException {
-    FileSystem fs = path.getFileSystem(conf);
     checkFileAccess(fs, path, action, SecurityUtils.getUGI());
   }
 

standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestHdfsUtils.java

@@ -33,6 +33,7 @@
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
@@ -174,6 +175,13 @@ public void otherNoExecute() throws IOException {
     HdfsUtils.checkFileAccess(fs, p, FsAction.EXECUTE, ugi);
   }
 
+  @Test (expected = FileNotFoundException.class)
+  public void nonExistentFile() throws IOException {
+    FileSystem fs = FileSystem.get(new Configuration());
+    Path p = new Path("/tmp/nosuchfile");
+    UserGroupInformation ugi = SecurityUtils.getUGI();
+    HdfsUtils.checkFileAccess(fs, p, FsAction.READ, ugi);
+  }
 
   @Test(expected = AccessControlException.class)
   public void accessPerssionFromCustomFilesystem() throws IOException {