fix: remove unreachable return statement in ListNamespaces

shangxinli · shangxinli · commit 91306fd4dd12 · 2025-12-31T09:40:25.000-08:00
The while(true) loop in RestCatalog::ListNamespaces only exits
via the return statement at line 151 when next_page_token is empty.
The return statement after the loop is unreachable dead code and
should be removed.
diff --git a/src/iceberg/catalog/rest/rest_catalog.cc b/src/iceberg/catalog/rest/rest_catalog.cc
@@ -152,7 +152,6 @@ Result<std::vector<Namespace>> RestCatalog::ListNamespaces(const Namespace& ns)
     }
     next_token = list_response.next_page_token;
   }
-  return result;
 }
 
 Status RestCatalog::CreateNamespace(

Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,6 @@ Result<std::vector<Namespace>> RestCatalog::ListNamespaces(const Namespace& ns)`
`152`	`152`	`}`
`153`	`153`	`next_token = list_response.next_page_token;`
`154`	`154`	`}`
`155`		`- return result;`
`156`	`155`	`}`
`157`	`156`
`158`	`157`	`Status RestCatalog::CreateNamespace(`