Skip to content

Commit e8bbf52

Browse files
committed
[KYUUBI #7229] Fix countMetadata if the params is empty
### Why are the changes needed? Without this PR. It will meet issue if the params is empty. ``` jdbcMetadataStore.countMetadata(MetadataFilter()) ``` <img width="1443" height="742" alt="image" src="https://github.com/user-attachments/assets/e099c469-7468-4d6a-90e8-e20ba144316b" /> <img width="877" height="160" alt="image" src="https://github.com/user-attachments/assets/1773d395-87f7-4108-ac6c-21c2ca04ca71" /> ### How was this patch tested? UT. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #7229 from turboFei/fix_typo. Closes #7229 c1794fe [Wang, Fei] Fix countMetadata if the params is empty Authored-by: Wang, Fei <[email protected]> Signed-off-by: Wang, Fei <[email protected]>
1 parent 3b205a3 commit e8bbf52

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ class JDBCMetadataStore(conf: KyuubiConf) extends MetadataStore with Logging {
280280
queryBuilder.append(s" ${assembleWhereClause(filter, params)}")
281281
val query = queryBuilder.toString
282282
JdbcUtils.executeQueryWithRowMapper(query) { stmt =>
283-
setStatementParams(stmt, params)
283+
setStatementParams(stmt, params: _*)
284284
} { resultSet =>
285285
resultSet.getInt(1)
286286
}.head

kyuubi-server/src/test/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStoreSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -224,6 +224,7 @@ class JDBCMetadataStoreSuite extends KyuubiFunSuite {
224224
jdbcMetadataStore.updateMetadata(newBatchState)
225225

226226
assert(jdbcMetadataStore.getMetadata(batchId) == newBatchState)
227+
assert(jdbcMetadataStore.countMetadata(MetadataFilter()) > 0)
227228

228229
assert(jdbcMetadataStore.getMetadataList(
229230
MetadataFilter(

0 commit comments

Comments
 (0)