Skip to content

Commit ea1d2ea

Browse files
author
wuziyi
committed
update
1 parent 3d9dde7 commit ea1d2ea

File tree

5 files changed

+12
-31
lines changed

5 files changed

+12
-31
lines changed

kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2390,12 +2390,12 @@ object KyuubiConf {
23902390
.booleanConf
23912391
.createWithDefault(true)
23922392

2393-
val ENGINE_EXTERNAL_ENABLED: ConfigEntry[Boolean] =
2393+
val ENGINE_EXTERNAL_TOKEN_ENABLED: ConfigEntry[Boolean] =
23942394
buildConf("kyuubi.engine.external.token.enabled")
2395-
.doc("start kerberos-enabled application with external delegation tokens")
2396-
.version("1.9.0")
2395+
.doc("Whether to start Kerberized engine with external delegation tokens.")
2396+
.version("1.11.0")
23972397
.booleanConf
2398-
.createWithDefault(true)
2398+
.createWithDefault(false)
23992399

24002400
val ENGINE_SHARE_LEVEL: ConfigEntry[String] = buildConf("kyuubi.engine.share.level")
24012401
.doc("Engines will be shared in different levels, available configs are: <ul>" +

kyuubi-server/src/main/scala/org/apache/kyuubi/credentials/YarnRMDelegationTokenProvider.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import org.apache.hadoop.yarn.util.ConverterUtils
2828

2929
import org.apache.kyuubi.Logging
3030
import org.apache.kyuubi.config.KyuubiConf
31+
import org.apache.kyuubi.config.KyuubiConf.ENGINE_EXTERNAL_TOKEN_ENABLED
3132
import org.apache.kyuubi.credentials.HadoopFsDelegationTokenProvider.doAsProxyUser
3233

3334
class YarnRMDelegationTokenProvider extends HadoopDelegationTokenProvider with Logging {
@@ -43,7 +44,7 @@ class YarnRMDelegationTokenProvider extends HadoopDelegationTokenProvider with L
4344
if (SecurityUtil.getAuthenticationMethod(hadoopConf) != AuthenticationMethod.SIMPLE) {
4445
yarnConf = new YarnConfiguration(hadoopConf)
4546
tokenService = ClientRMProxy.getRMDelegationTokenService(yarnConf)
46-
required = true
47+
required = kyuubiConf.get(ENGINE_EXTERNAL_TOKEN_ENABLED)
4748
}
4849
}
4950

kyuubi-server/src/main/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilder.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ class SparkProcessBuilder(
6161
import SparkProcessBuilder._
6262

6363
private[kyuubi] val sparkHome = getEngineHome(shortName)
64-
private[kyuubi] val externalTokensEnabled = conf.get(ENGINE_EXTERNAL_ENABLED)
64+
private[kyuubi] val externalTokensEnabled = conf.get(ENGINE_EXTERNAL_TOKEN_ENABLED)
6565

6666
override protected val executable: String = {
6767
Paths.get(sparkHome, "bin", SPARK_SUBMIT_FILE).toFile.getCanonicalPath

kyuubi-server/src/test/scala/org/apache/kyuubi/credentials/YarnDelegationTokenProviderSuite.scala

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ class YarnDelegationTokenProviderSuite extends WithSecuredYarnCluster {
3434

3535
val hadoopConf = getHadoopConf
3636
val kyuubiConf = new KyuubiConf(false)
37+
kyuubiConf.set("kyuubi.engine.external.token.enabled", "true")
3738

3839
val provider = new YarnRMDelegationTokenProvider
3940
provider.initialize(hadoopConf, kyuubiConf)

kyuubi-server/src/test/scala/org/apache/kyuubi/engine/spark/SparkProcessBuilderSuite.scala

Lines changed: 4 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -488,32 +488,11 @@ class SparkProcessBuilderSuite extends KerberizedTestHelper with MockitoSugar {
488488

489489
test("spark engine with external token file") {
490490
val conf1 = KyuubiConf(false)
491-
val tokenStr = "SERUUwAID2hhLWhkZnM6cmVkcG9sbD8ABmhhZG9vcAAfaGl2ZS9oaXZl" +
492-
"c2VydmVyQE5JRS5ORVRFQVNFLkNPTYoBmEC/zomKAZhkzFKJjEQmld6OB4YUpNYg2W5h9" +
493-
"+2R2gWTPCf0Ut/Qr9QVSERGU19ERUxFR0FUSU9OX1RPS0VOD2hhLWhkZnM6cmVkcG9sbB" +
494-
"FoYS1oZGZzOmZlbmdodWFuZz8ABmhhZG9vcAAfaGl2ZS9oaXZlc2VydmVyQE5JRS5ORVR" +
495-
"FQVNFLkNPTYoBmEC/zu2KAZhkzFLtjCqL5mKOEtAUbr+Tl2CACTcgnvac9RcxZAoMq28V" +
496-
"SERGU19ERUxFR0FUSU9OX1RPS0VOEWhhLWhkZnM6ZmVuZ2h1YW5ndnRocmlmdDovL3NkY" +
497-
"y5mZW5naHVhbmcud2FnZ2xlZGFuY2UuZ2RjLm5pZS5uZXRlYXNlLmNvbToyMDA1MCx0aH" +
498-
"JpZnQ6Ly8xMC4xOTEuNTkuMTYyOjIwMDUwLHRocmlmdDovLzEwLjE5MS41OS4xNjM6MjA" +
499-
"wNTApAAZoYWRvb3AEaGl2ZQRoaXZligGYQL/PVYoBmGTMU1WMAVM2x40BBgsUIKFw7GME" +
500-
"1U6N/ZhxObek/I1RA0sVSElWRV9ERUxFR0FUSU9OX1RPS0VOAA9oYS1oZGZzOmRpamlhb" +
501-
"mc/AAZoYWRvb3AAH2hpdmUvaGl2ZXNlcnZlckBOSUUuTkVURUFTRS5DT02KAZhAv89Hig" +
502-
"GYZMxTR4wBz4hHjgGVFOfgiMNZ/B2acCmYkV7P0euzVBXWFUhERlNfREVMRUdBVElPTl9" +
503-
"UT0tFTg9oYS1oZGZzOmRpamlhbmcPaGEtaGRmczpqaW5nd2VpPwAGaGFkb29wAB9oaXZl" +
504-
"L2hpdmVzZXJ2ZXJATklFLk5FVEVBU0UuQ09NigGYQL/PIYoBmGTMUyGMIPu5VY4WwBQH9" +
505-
"xpTeUCxroeNIOCW0908k1ZbSBVIREZTX0RFTEVHQVRJT05fVE9LRU4PaGEtaGRmczpqaW" +
506-
"5nd2VpEWhhLWhkZnM6aHVhbmdsb25nPwAGaGFkb29wAB9oaXZlL2hpdmVzZXJ2ZXJATkl" +
507-
"FLk5FVEVBU0UuQ09NigGYQL/PAIoBmGTMUwCMHv0cmI4bCBQOKo3I+WxPcz+nrXlGdbZ/" +
508-
"nCPKyRVIREZTX0RFTEVHQVRJT05fVE9LRU4RaGEtaGRmczpodWFuZ2xvbmcSaGEtaGRmc" +
509-
"zpnZGNjbHVzdGVyPwAGaGFkb29wAB9oaXZlL2hpdmVzZXJ2ZXJATklFLk5FVEVBU0UuQ0" +
510-
"9NigGYQL/OvYoBmGTMUr2Ef72TD44URBSQajq5T6KZuMgk7cFuIHz7PAvGixVIREZTX0R" +
511-
"FTEVHQVRJT05fVE9LRU4SaGEtaGRmczpnZGNjbHVzdGVyE2hhLWhkZnM6Z2RjY2x1c3Rl" +
512-
"cjI/AAZoYWRvb3AAH2hpdmUvaGl2ZXNlcnZlckBOSUUuTkVURUFTRS5DT02KAZhAv88Qi" +
513-
"gGYZMxTEIwSFo7AjgepFEwXJHRr7YVk7fxXxfRcbElkLI1QFUhERlNfREVMRUdBVElPTl" +
514-
"9UT0tFThNoYS1oZGZzOmdkY2NsdXN0ZXIyAA=="
491+
val tokenStr = "SERUUwABDzEyNy4wLjAuMTo0NTQ2MkIKA3dobxopY2xpZW50L2xvY2FsaG9zdEBLRVJC" +
492+
"RVJJWkVEVEVTVEhFTFBFUi5DT00guMuGgJEzKLjTuKCTMzABOAIUqTa2O5pYh2dBXFNnpqEgIJvWF5sTU" +
493+
"k1fREVMRUdBVElPTl9UT0tFTg8xMjcuMC4wLjE6NDU0NjIA"
515494
conf1.set(KYUUBI_ENGINE_CREDENTIALS_KEY, tokenStr)
516-
conf1.set(ENGINE_EXTERNAL_ENABLED, true)
495+
conf1.set(ENGINE_EXTERNAL_TOKEN_ENABLED, true)
517496
val builder1 = new SparkProcessBuilder("", true, conf1)
518497
assert(builder1.env.contains(HADOOP_TOKEN_FILE_LOCATION))
519498
assert(builder1.env.contains(ENV_KERBEROS_TGT) &&

0 commit comments

Comments
 (0)