Skip to content

Conversation

@ArnavBalyan
Copy link
Member

@ArnavBalyan ArnavBalyan commented Sep 9, 2025

Rationale for this change

Before:

{
  "type" : "record",
  "name" : "int96Schema",
  "fields" : [ {
    "name" : "timestamp_1",
    "type" : [ "null", {
      "type" : "fixed",
      "name" : "INT96",
      "doc" : "INT96 represented as byte[12]",
      "size" : 12
    } ],
    "default" : null
  }, {
    "name" : "timestamp_2",
    "type" : [ "null", "INT96" ],
    "default" : null
  } ]
}

After:

{
  "type" : "record",
  "name" : "int96Schema",
  "fields" : [ {
    "name" : "timestamp_1",
    "type" : [ "null", {
      "type" : "fixed",
      "name" : "timestamp_1",
      "doc" : "INT96 represented as byte[12]",
      "size" : 12
    } ],
    "default" : null
  }, {
    "name" : "timestamp_2",
    "type" : [ "null", {
      "type" : "fixed",
      "name" : "timestamp_2",
      "doc" : "INT96 represented as byte[12]",
      "size" : 12
    } ],
    "default" : null
  } ]
}

Are these changes tested?

  • Yes

Are there any user-facing changes?

  • Yes

Closes: #2972

@ArnavBalyan
Copy link
Member Author

cc @gszadovszky : )

@ArnavBalyan
Copy link
Member Author

cc @gszadovszky could you please merge it if all looks good thanks!

@wgtmac wgtmac merged commit f50dd6c into apache:master Sep 21, 2025
7 checks passed
@wgtmac
Copy link
Member

wgtmac commented Sep 21, 2025

Merged it. Thanks @ArnavBalyan for working on this and @gszadovszky for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AvroSchemaConverter toString() conversion when schema has multiple INT96 fields

3 participants