Skip to content

THRIFT-5885: Python incorrectly deserializes Enum #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −9
Open

THRIFT-5885: Python incorrectly deserializes Enum #3232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9537e7
THRIFT-5885 Fix enum generation
CJCombrink Nov 10, 2025
6e8a222
Try to re-enable the enum tests
CJCombrink Nov 10, 2025
eea27eb
Put back type_hints for python after 3.7
CJCombrink Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/cpp/src/thrift/generate/t_py_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,8 +984,8 @@ void t_py_generator::generate_py_struct_definition(ostream& out,
t_type* type = (*m_iter)->get_type();
if (type->is_enum()) {
out << indent() << "if name == \"" << (*m_iter)->get_name() << "\":" << '\n'
<< indent() << indent_str() << "super().__setattr__(name, value if hasattr(value, 'value') else "
<< type_name(type) << ".__members__.get(value))" << '\n'
<< indent() << indent_str() << "super().__setattr__(name, value if hasattr(value, 'value') or value is None else "
<< type_name(type) << "(value))" << '\n'
<< indent() << indent_str() << "return" << '\n';
}
}
Expand Down
9 changes: 2 additions & 7 deletions test/py/RunClientServer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,13 +285,8 @@ def main():

generated_dirs = []
for gp_dir in options.genpydirs.split(','):
if gp_dir == 'type_hints':
# Skip type hints tests -> See THRIFT-5885 (it might be related)
print('Skipping \'type_hints\' tests')
continue
if gp_dir == 'enum':
# Skip enum tests -> See THRIFT-5885
print('Skipping \'enum\' tests')
if gp_dir == 'type_hints' and (sys.version_info < (3,7)):
print('Skipping \'type_hints\' test since python 3.7 or later is required')
continue
generated_dirs.append('gen-py-%s' % (gp_dir))

Expand Down