Skip to content

Commit 89c1f77

Browse files
committed
fix: add mkdocs-eds explicitely while waiting for py38 drop
1 parent 1f96172 commit 89c1f77

File tree

9 files changed

+13
-42
lines changed

9 files changed

+13
-42
lines changed

.github/copilot-instructions.md

Lines changed: 0 additions & 30 deletions
This file was deleted.

.github/workflows/documentation.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131

3232
- name: Install dependencies
3333
run: |
34-
pip install '.[docs]'
34+
pip install '.[docs]' "mkdocs-eds@git+https://github.com/aphp/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'"
3535
# uv venv
3636
# uv pip install '.[docs]'
3737

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ jobs:
8888
- name: Install dependencies
8989
run: |
9090
python -m pip install --upgrade pip
91-
pip install '.[docs]'
91+
pip install '.[docs]' "mkdocs-eds@git+https://github.com/aphp/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'"
9292
9393
- name: Set up Git
9494
run: |

.github/workflows/tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,16 +61,16 @@ jobs:
6161
cache: 'pip'
6262

6363
- name: Install dependencies
64-
run: pip install -e ".[dev]"
64+
run: pip install -e ".[dev]" "mkdocs-eds@git+https://github.com/aphp/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'"
6565
if: matrix.python-version != '3.9' && matrix.python-version != '3.10' && matrix.python-version != '3.11' && matrix.python-version != '3.12'
6666

6767
- name: Install dependencies
68-
run: pip install -e ".[dev,setup]"
68+
run: pip install -e ".[dev,setup]" "mkdocs-eds@git+https://github.com/aphp/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'"
6969
if: matrix.python-version == '3.9'
7070

7171
- name: Install dependencies
7272
# skip ML tests for 3.10 and 3.11
73-
run: pip install -e ".[dev-no-ml]"
73+
run: pip install -e ".[dev-no-ml]" "mkdocs-eds@git+https://github.com/aphp/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'"
7474
if: matrix.python-version == '3.10' || matrix.python-version == '3.11' || matrix.python-version == '3.12'
7575

7676
- name: Test with Pytest on Python ${{ matrix.python-version }}
@@ -118,7 +118,7 @@ jobs:
118118
cache: 'pip'
119119

120120
- name: Install dependencies
121-
run: pip install -e ".[docs]"
121+
run: pip install -e ".[docs]" "mkdocs-eds@git+https://github.com/aphp/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'"
122122

123123
- name: Set up Git
124124
run: |

changelog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
## v0.18.0 (2025-09-02)
44

5+
📢 EDS-NLP will drop support for Python 3.7, 3.8 and 3.9 support in the next major release (v0.19.0), in October 2025. Please upgrade to Python 3.10 or later.
6+
57
### Added
68

79
- Added support for multiple loggers (`tensorboard`, `wandb`, `comet_ml`, `aim`, `mlflow`, `clearml`, `dvclive`, `csv`, `json`, `rich`) in `edsnlp.train` via the `logger` parameter. Default is [`json` and `rich`] for backward compatibility.

contributing.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ $ python -m venv venv
2424
$ source venv/bin/activate
2525

2626
# Install the package with common, dev, setup dependencies in editable mode
27-
$ pip install -e '.[dev,setup]'
27+
$ pip install -e '.[dev,setup]' "mkdocs-eds@git+https://github.com/aphp/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'"
2828
# And build resources
2929
$ python scripts/conjugate_verbs.py
3030
```
@@ -107,13 +107,13 @@ Most modern editors propose extensions that will format files on save.
107107
Make sure to document your improvements, both within the code with comprehensive docstrings,
108108
as well as in the documentation itself if need be.
109109

110-
We use `MkDocs` for EDS-NLP's documentation. You can checkout the changes you make with:
110+
We use `MkDocs` for EDS-NLP's documentation. You can check out the changes you make with:
111111

112112
<div class="termy">
113113

114114
```console
115115
# Install the requirements
116-
$ pip install -e '.[docs]'
116+
$ pip install -e '.[docs]' "mkdocs-eds@git+https://github.com/aphp/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'"
117117
---> 100%
118118
color:green Installation successful
119119

edsnlp/metrics/span_attribute.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ class SpanAttributeMetric:
156156
the Average Precision (ap). A micro‐average over all attributes is also
157157
provided under `micro_key`.
158158
159-
```python
159+
```python { .no-check }
160160
from edsnlp.metrics.span_attribute import SpanAttributeMetric
161161
162162
metric = SpanAttributeMetric(

mkdocs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ watch:
187187

188188
plugins:
189189
- auto_gen_pages:
190-
package_dirs: ["pret"]
190+
package_dirs: ["edsnlp"]
191191
reference_section: Reference
192192
exclude_glob: assets/fragments/*
193193
copy_files:

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ dev-no-ml = [
6464
"edsnlp[docs-no-ml]",
6565
]
6666
docs-no-ml = [
67-
"mkdocs-eds @ git+https://github.com/percevalw/mkdocs-eds.git@main#egg=mkdocs-eds ; python_version>='3.9'",
6867
"markdown-grid-tables==0.4.0; python_version>='3.9'",
6968
]
7069
ml = [

0 commit comments

Comments
 (0)