Fix windows tests after cleanup

Author: vdusek

src/crawlee/_consts.py

@@ -1,3 +1,4 @@
 from __future__ import annotations
 
 METADATA_FILENAME = '__metadata__.json'
+"""The name of the metadata file for storage clients."""

src/crawlee/_utils/file.py

@@ -4,22 +4,19 @@
 import csv
 import json
 import os
+import tempfile
+from pathlib import Path
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
     from collections.abc import AsyncIterator
-    from pathlib import Path
     from typing import Any, TextIO
 
     from typing_extensions import Unpack
 
     from crawlee._types import ExportDataCsvKwargs, ExportDataJsonKwargs
 
 
-METADATA_FILENAME = '__metadata__.json'
-"""The name of the metadata file for storage clients."""
-
-
 def infer_mime_type(value: Any) -> str:
     """Infer the MIME content type from the value.
 
@@ -58,26 +55,55 @@ async def json_dumps(obj: Any) -> str:
 
 
 async def atomic_write_text(path: Path, data: str) -> None:
-    tmp = path.with_suffix(path.suffix + '.tmp')
-    # write to .tmp
-    await asyncio.to_thread(tmp.write_text, data, encoding='utf-8')
+    dir_path = path.parent
+
+    def _sync_write_text() -> str:
+        # create a temp file in the target dir, return its name
+        fd, tmp_path = tempfile.mkstemp(
+            suffix=path.suffix,
+            prefix=f'{path.name}.',
+            dir=str(dir_path),
+        )
+        try:
+            with os.fdopen(fd, 'w', encoding='utf-8') as tmp_file:
+                tmp_file.write(data)
+        except:
+            Path(tmp_path).unlink(missing_ok=True)
+            raise
+        return tmp_path
+
+    tmp_path = await asyncio.to_thread(_sync_write_text)
 
     try:
-        await asyncio.to_thread(os.replace, tmp, path)
-    except FileNotFoundError:
-        # If the .tmp vanished, fall back to a straight write
+        await asyncio.to_thread(os.replace, tmp_path, str(path))
+    except (FileNotFoundError, PermissionError):
+        # fallback if tmp went missing
         await asyncio.to_thread(path.write_text, data, encoding='utf-8')
 
 
 async def atomic_write_bytes(path: Path, data: bytes) -> None:
-    tmp = path.with_suffix(path.suffix + '.tmp')
-    # write to .tmp
-    await asyncio.to_thread(tmp.write_bytes, data)
+    dir_path = path.parent
+
+    def _sync_write_bytes() -> str:
+        fd, tmp_path = tempfile.mkstemp(
+            suffix=path.suffix,
+            prefix=f'{path.name}.',
+            dir=str(dir_path),
+        )
+        try:
+            with os.fdopen(fd, 'wb') as tmp_file:
+                tmp_file.write(data)
+        except:
+            Path(tmp_path).unlink(missing_ok=True)
+            raise
+        return tmp_path
+
+    tmp_path = await asyncio.to_thread(_sync_write_bytes)
 
     try:
-        await asyncio.to_thread(os.replace, tmp, path)
-    except FileNotFoundError:
-        # If the .tmp vanished, fall back to a straight write
+        await asyncio.to_thread(os.replace, tmp_path, str(path))
+    except (FileNotFoundError, PermissionError):
+        # fallback if tmp went missing
         await asyncio.to_thread(path.write_bytes, data)
 
 

src/crawlee/storage_clients/_file_system/_dataset_client.py

@@ -11,8 +11,9 @@
 from pydantic import ValidationError
 from typing_extensions import override
 
+from crawlee._consts import METADATA_FILENAME
 from crawlee._utils.crypto import crypto_random_object_id
-from crawlee._utils.file import METADATA_FILENAME, atomic_write_text, json_dumps
+from crawlee._utils.file import atomic_write_text, json_dumps
 from crawlee.storage_clients._base import DatasetClient
 from crawlee.storage_clients.models import DatasetItemsListPage, DatasetMetadata
 

src/crawlee/storage_clients/_file_system/_key_value_store_client.py

@@ -12,8 +12,9 @@
 from pydantic import ValidationError
 from typing_extensions import override
 
+from crawlee._consts import METADATA_FILENAME
 from crawlee._utils.crypto import crypto_random_object_id
-from crawlee._utils.file import METADATA_FILENAME, atomic_write_bytes, atomic_write_text, infer_mime_type, json_dumps
+from crawlee._utils.file import atomic_write_bytes, atomic_write_text, infer_mime_type, json_dumps
 from crawlee.storage_clients._base import KeyValueStoreClient
 from crawlee.storage_clients.models import KeyValueStoreMetadata, KeyValueStoreRecord, KeyValueStoreRecordMetadata
 

src/crawlee/storage_clients/_file_system/_request_queue_client.py

@@ -12,8 +12,9 @@
 from typing_extensions import override
 
 from crawlee import Request
+from crawlee._consts import METADATA_FILENAME
 from crawlee._utils.crypto import crypto_random_object_id
-from crawlee._utils.file import METADATA_FILENAME, atomic_write_text, json_dumps
+from crawlee._utils.file import atomic_write_text, json_dumps
 from crawlee.storage_clients._base import RequestQueueClient
 from crawlee.storage_clients.models import AddRequestsResponse, ProcessedRequest, RequestQueueMetadata