Skip to content

Commit 637f032

Browse files
jerelmillerjerelmiller
committed
Swap order of arguments to incremental handler
1 parent 9b9d8aa commit 637f032

File tree

8 files changed

+371
-438
lines changed

8 files changed

+371
-438
lines changed

‎src/core/QueryInfo.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ export class QueryInfo<
195195
DataValue.Complete<TData> | DataValue.Streaming<TData>
196196
>;
197197

198-
return this.incremental.handle(cacheData, incoming);
198+
return this.incremental.handle(incoming, cacheData);
199199
}
200200
return incoming;
201201
}

‎src/incremental/handlers/__tests__/defer20220824/defer.test.ts‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ describe("graphql-js test cases", () => {
134134
assert(!done);
135135
assert(handler.isIncrementalResult(chunk));
136136
expect(hasIncrementalChunks(chunk)).toBe(false);
137-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
137+
expect(request.handle(chunk)).toStrictEqualTyped({
138138
data: {
139139
hero: {
140140
id: "1",
@@ -148,7 +148,7 @@ describe("graphql-js test cases", () => {
148148
assert(!done);
149149
assert(handler.isIncrementalResult(chunk));
150150
expect(hasIncrementalChunks(chunk)).toBe(true);
151-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
151+
expect(request.handle(chunk)).toStrictEqualTyped({
152152
data: {
153153
hero: {
154154
id: "1",
@@ -202,7 +202,7 @@ describe("graphql-js test cases", () => {
202202
assert(!done);
203203
assert(handler.isIncrementalResult(chunk));
204204
expect(hasIncrementalChunks(chunk)).toBe(false);
205-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
205+
expect(request.handle(chunk)).toStrictEqualTyped({
206206
data: {},
207207
});
208208
expect(request.hasNext).toBe(true);
@@ -212,7 +212,7 @@ describe("graphql-js test cases", () => {
212212
assert(!done);
213213
assert(handler.isIncrementalResult(chunk));
214214
expect(hasIncrementalChunks(chunk)).toBe(true);
215-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
215+
expect(request.handle(chunk)).toStrictEqualTyped({
216216
data: {
217217
hero: {
218218
id: "1",
@@ -243,7 +243,7 @@ describe("graphql-js test cases", () => {
243243
assert(!done);
244244
assert(handler.isIncrementalResult(chunk));
245245
expect(hasIncrementalChunks(chunk)).toBe(false);
246-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
246+
expect(request.handle(chunk)).toStrictEqualTyped({
247247
data: {},
248248
});
249249
expect(request.hasNext).toBe(true);
@@ -253,7 +253,7 @@ describe("graphql-js test cases", () => {
253253
assert(!done);
254254
assert(handler.isIncrementalResult(chunk));
255255
expect(hasIncrementalChunks(chunk)).toBe(true);
256-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
256+
expect(request.handle(chunk)).toStrictEqualTyped({
257257
data: {
258258
hero: {
259259
errorField: null,
@@ -297,7 +297,7 @@ describe("graphql-js test cases", () => {
297297
assert(!done);
298298
assert(handler.isIncrementalResult(chunk));
299299
expect(hasIncrementalChunks(chunk)).toBe(false);
300-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
300+
expect(request.handle(chunk)).toStrictEqualTyped({
301301
data: {
302302
hero: {
303303
id: "1",
@@ -312,7 +312,7 @@ describe("graphql-js test cases", () => {
312312

313313
assert(handler.isIncrementalResult(chunk));
314314
expect(hasIncrementalChunks(chunk)).toBe(true);
315-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
315+
expect(request.handle(chunk)).toStrictEqualTyped({
316316
data: {
317317
hero: {
318318
id: "1",
@@ -348,7 +348,7 @@ describe("graphql-js test cases", () => {
348348

349349
assert(handler.isIncrementalResult(chunk));
350350
expect(hasIncrementalChunks(chunk)).toBe(false);
351-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
351+
expect(request.handle(chunk)).toStrictEqualTyped({
352352
data: {
353353
hero: { id: "1", name: "Luke" },
354354
},
@@ -361,7 +361,7 @@ describe("graphql-js test cases", () => {
361361

362362
assert(handler.isIncrementalResult(chunk));
363363
expect(hasIncrementalChunks(chunk)).toBe(true);
364-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
364+
expect(request.handle(chunk)).toStrictEqualTyped({
365365
data: {
366366
hero: {
367367
id: "1",
@@ -401,7 +401,7 @@ describe("graphql-js test cases", () => {
401401
assert(!done);
402402
assert(handler.isIncrementalResult(chunk));
403403
expect(hasIncrementalChunks(chunk)).toBe(false);
404-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
404+
expect(request.handle(chunk)).toStrictEqualTyped({
405405
data: { hero: { id: "1" } },
406406
});
407407
expect(request.hasNext).toBe(true);
@@ -411,7 +411,7 @@ describe("graphql-js test cases", () => {
411411
assert(!done);
412412
assert(handler.isIncrementalResult(chunk));
413413
expect(hasIncrementalChunks(chunk)).toBe(true);
414-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
414+
expect(request.handle(chunk)).toStrictEqualTyped({
415415
data: {
416416
hero: {
417417
id: "1",
@@ -450,7 +450,7 @@ describe("graphql-js test cases", () => {
450450
assert(!done);
451451
assert(handler.isIncrementalResult(chunk));
452452
expect(hasIncrementalChunks(chunk)).toBe(false);
453-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
453+
expect(request.handle(chunk)).toStrictEqualTyped({
454454
data: { hero: { id: "1" } },
455455
});
456456
expect(request.hasNext).toBe(true);
@@ -460,7 +460,7 @@ describe("graphql-js test cases", () => {
460460
assert(!done);
461461
assert(handler.isIncrementalResult(chunk));
462462
expect(hasIncrementalChunks(chunk)).toBe(true);
463-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
463+
expect(request.handle(chunk)).toStrictEqualTyped({
464464
data: {
465465
hero: {
466466
id: "1",
@@ -531,7 +531,7 @@ describe("graphql-js test cases", () => {
531531
assert(!done);
532532
assert(handler.isIncrementalResult(chunk));
533533
expect(hasIncrementalChunks(chunk)).toBe(false);
534-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
534+
expect(request.handle(chunk)).toStrictEqualTyped({
535535
data: { hero: { id: "1" } },
536536
});
537537
expect(request.hasNext).toBe(true);
@@ -541,7 +541,7 @@ describe("graphql-js test cases", () => {
541541
assert(!done);
542542
assert(handler.isIncrementalResult(chunk));
543543
expect(hasIncrementalChunks(chunk)).toBe(true);
544-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
544+
expect(request.handle(chunk)).toStrictEqualTyped({
545545
data: {
546546
hero: {
547547
id: "1",
@@ -557,7 +557,7 @@ describe("graphql-js test cases", () => {
557557
assert(!done);
558558
assert(handler.isIncrementalResult(chunk));
559559
expect(hasIncrementalChunks(chunk)).toBe(true);
560-
expect(request.handle(undefined, chunk)).toStrictEqualTyped({
560+
expect(request.handle(chunk)).toStrictEqualTyped({
561561
data: {
562562
hero: {
563563
id: "1",

0 commit comments

Comments
 (0)