Skip to content

Commit aba8143

Browse files
committed
Fix protoc incantations
1 parent d27f960 commit aba8143

File tree

1 file changed

+9
-15
lines changed

1 file changed

+9
-15
lines changed

Performance/perf_runner.sh

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,8 @@ function profile_harness() {
153153
echo "Running $description test harness in Instruments..."
154154
mkdir -p "$results_trace"
155155
xctrace record --template 'Time Profiler' --output "$results_trace" \
156-
--env DYLD_LIBRARY_PATH="$perf_dir/_generated" \
157-
--launch -- "$harness"
156+
--env DYLD_LIBRARY_PATH="$perf_dir/_generated" \
157+
--launch -- "$harness"
158158
}
159159

160160
# Inserts the partial visualization results from all the languages tested into
@@ -238,7 +238,7 @@ fi
238238
# Set up a hook to cleanup revision comparison checkouts when the script
239239
# completes.
240240
declare -a CLEANUP_WHEN_DONE
241-
declare -a GIT_WORKTREE
241+
GIT_WORKTREE=""
242242
function cleanup_revision_checkouts() {
243243
if [[ "${#CLEANUP_WHEN_DONE[@]}" -ne 0 ]]; then
244244
rm -rf "${CLEANUP_WHEN_DONE[@]}"
@@ -303,7 +303,9 @@ for comparison in "${comparisons[@]}"; do
303303
echo "==== Building/running C++ harness ===================="
304304
echo
305305

306-
${PROTOC} --cpp_out="$script_dir" "$gen_message_path"
306+
${PROTOC} --cpp_out="$script_dir/_generated" \
307+
--proto_path=`dirname $gen_message_path` \
308+
"$gen_message_path"
307309

308310
harness_cpp="$script_dir/_generated/harness_cpp"
309311
run_cpp_harness "$harness_cpp"
@@ -326,14 +328,10 @@ for comparison in "${comparisons[@]}"; do
326328
mkdir "$GIT_WORKTREE/Performance/_generated"
327329

328330
build_swift_packages "$GIT_WORKTREE" "ForRev"
329-
echo ${PROTOC} --plugin="$GIT_WORKTREE/.build/release/protoc-gen-swiftForRev" \
330-
--swiftForRev_out=FileNaming=DropPath:"$GIT_WORKTREE/Performance/_generated" \
331-
--proto_path=`dirname $gen_message_path` \
332-
"$gen_message_path"
333331
${PROTOC} --plugin="$GIT_WORKTREE/.build/release/protoc-gen-swiftForRev" \
334-
--swiftForRev_out=FileNaming=DropPath:"$GIT_WORKTREE/Performance/_generated" \
335-
--proto_path=`dirname $gen_message_path` \
336-
"$gen_message_path"
332+
--swiftForRev_out=FileNaming=DropPath:"$GIT_WORKTREE/Performance/_generated" \
333+
--proto_path=`dirname $gen_message_path` \
334+
"$gen_message_path"
337335

338336
harness_swift="$GIT_WORKTREE/Performance/_generated/harness_swift"
339337
results_trace="$script_dir/_results/$report_type (swift)"
@@ -352,10 +350,6 @@ echo "==== Building/running Swift harness (working tree) ===================="
352350
echo
353351

354352
build_swift_packages "$script_dir/.." "ForWorkTree"
355-
${PROTOC} --plugin="$script_dir/../.build/release/protoc-gen-swiftForWorkTree" \
356-
--swiftForWorkTree_out=FileNaming=DropPath:"$script_dir/_generated" \
357-
--cpp_out="$script_dir" \
358-
"$gen_message_path"
359353

360354
harness_swift="$script_dir/_generated/harness_swift"
361355
results_trace="$script_dir/_results/$report_type (swift)"

0 commit comments

Comments
 (0)