Skip to content

Commit df7ba56

Browse files
authored
Merge pull request #1131 from appwrite/allow-internal-attributes-partially
chore: allow internal attributes partially in web and node
2 parents c9ebf8d + 727e2df commit df7ba56

File tree

4 files changed

+4
-16
lines changed

4 files changed

+4
-16
lines changed

src/SDK/Language/Node.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,10 @@ public function getTypeName(array $parameter, array $method = []): string
5757
return "Partial<Preferences>";
5858
case 'document':
5959
if ($method['method'] === 'post') {
60-
return "Document extends Models.DefaultDocument ? Models.DataWithoutDocumentKeys : Omit<Document, keyof Models.Document>";
60+
return "Document extends Models.DefaultDocument ? Partial<Models.Document> & Record<string, any> : Partial<Models.Document> & Omit<Document, keyof Models.Document>";
6161
}
6262
if ($method['method'] === 'patch') {
63-
return "Partial<Document extends Models.DefaultDocument ? Models.DataWithoutDocumentKeys : Omit<Document, keyof Models.Document>>";
63+
return "Document extends Models.DefaultDocument ? Partial<Models.Document> & Record<string, any> : Partial<Models.Document> & Partial<Omit<Document, keyof Models.Document>>";
6464
}
6565
}
6666
break;

src/SDK/Language/Web.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -222,10 +222,10 @@ public function getTypeName(array $parameter, array $method = []): string
222222
return "Partial<Preferences>";
223223
case 'document':
224224
if ($method['method'] === 'post') {
225-
return "Document extends Models.DefaultDocument ? Models.DataWithoutDocumentKeys : Omit<Document, keyof Models.Document>";
225+
return "Document extends Models.DefaultDocument ? Partial<Models.Document> & Record<string, any> : Partial<Models.Document> & Omit<Document, keyof Models.Document>";
226226
}
227227
if ($method['method'] === 'patch') {
228-
return "Partial<Document extends Models.DefaultDocument ? Models.DataWithoutDocumentKeys : Omit<Document, keyof Models.Document>>";
228+
return "Document extends Models.DefaultDocument ? Partial<Models.Document> & Record<string, any> : Partial<Models.Document> & Partial<Omit<Document, keyof Models.Document>>";
229229
}
230230
}
231231
break;

templates/react-native/src/models.ts.twig

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@ export namespace Models {
2020
[key: string]: any;
2121
[__default]: true;
2222
};
23-
24-
export type DataWithout{{ definition.name | caseUcfirst }}Keys{{ definition.name | getGenerics(spec, true) | raw }} = {
25-
[K in string]: any;
26-
} & {
27-
[K in keyof {{ definition.name | caseUcfirst }}{{ definition.name | getGenerics(spec, true) | raw }}]?: never;
28-
};
2923
{% endif %}
3024
{% endfor %}
3125
}

templates/web/src/models.ts.twig

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,6 @@ export namespace Models {
2323
[key: string]: any;
2424
[__default]: true;
2525
};
26-
27-
export type DataWithout{{ definition.name | caseUcfirst }}Keys{{ definition.name | getGenerics(spec, true) | raw }} = {
28-
[K in string]: any;
29-
} & {
30-
[K in keyof {{ definition.name | caseUcfirst }}{{ definition.name | getGenerics(spec, true) | raw }}]?: never;
31-
};
3226
{% endif %}
3327
{% endfor %}
3428
}

0 commit comments

Comments
 (0)