format-check: add collect errors job

The Github UI for required checks does not integrate with the workflows
described in the .github directory. Currently jobs that are never
started due to conditional execution are not even reported, so the UI
shows "expected" and locks up merges.

Collect format errors so that the Github UI can be happy to track one job that
is always executed. This job will fail if any of the format-check jobs
failed or were cancelled, and will be ignored (but reported) otherwise.

Signed-off-by: Luca Burelli <[email protected]>

Author: pillo79

.github/workflows/format_check.yml

@@ -4,11 +4,6 @@ on:
   push:
     branches:
       - 'main'
-    paths:
-      - '**/*.c'
-      - '**/*.cpp'
-      - '**/*.h'
-      - '**/*.hpp'
 
   pull_request:
     types:
@@ -18,11 +13,6 @@ on:
       - synchronize
     branches:
       - 'main'
-    paths:
-      - '**/*.c'
-      - '**/*.cpp'
-      - '**/*.h'
-      - '**/*.hpp'
 
   workflow_dispatch:
     inputs:
@@ -32,29 +22,70 @@ on:
         default: 'warning'
 
 jobs:
+  filter-format-check:
+    runs-on: ubuntu-latest
+    outputs: 
+      core_any_changed: ${{ steps.changed-files.outputs.core_any_changed }}
+      loader_any_changed: ${{ steps.changed-files.outputs.loader_any_changed }}
+      libraries_any_changed: ${{ steps.changed-files.outputs.libraries_any_changed }}
+    steps:
+      - name: Get changed source files
+        id: changed-files
+        uses: tj-actions/changed-files@
+        with:
+          files_yaml: |
+            core:
+              - cores/arduino/**/*.{c,cpp,h,hpp}
+              - '!cores/arduino/api/**'
+            loader:
+              - loader/**/*.{c,cpp,h,hpp}
+              - '!loader/llext_exports.c'
+            libraries:
+              - libraries/**/*.{c,cpp,h,hpp}
+              - '!libraries/examples/**'
+              - '!libraries/extras/**'
+              - '!libraries/ea_malloc/**'
+
   format-check:
     runs-on: ubuntu-latest
+    needs:
+      - filter-format-check
     strategy:
       matrix:
         path:
-          - check: 'cores/arduino/'
+          - name: 'core'
+            check: 'cores/arduino/'
             exclude: 'cores/arduino/api/'
-          - check: 'loader/'
+          - name: 'loader'
+            check: 'loader/'
             exclude: 'loader/llext_exports\.c$'
-          - check: 'libraries/'
+          - name: 'libraries'
+            check: 'libraries/'
             exclude: '(examples|extras|ea_malloc)'
       fail-fast: false
 
     steps:
       - name: Checkout code
+        if: needs.filter-format-check.outputs.${{ matrix.path['name'] }}_any_changed == 'true'
         uses: actions/checkout@v4
         with:
           submodules: false
           persist-credentials: false
 
       - name: Run clang-format check
+        if: needs.filter-format-check.outputs.${{ matrix.path['name'] }}_any_changed == 'true'
         uses: jidicula/[email protected]
         with:
           clang-format-version: '19'
           check-path: ${{ matrix.path['check'] }}
           exclude-regex: ${{ matrix.path['exclude'] }}
+
+  verify-format:
+    name: Collect job errors
+    runs-on: ubuntu-latest
+    if: cancelled() || contains(needs.*.result, 'failure')
+    needs:
+      - format-check
+    steps: 
+      - name: Notify failure
+        run: exit 1

west.yml

@@ -26,14 +26,15 @@ manifest:
         name-allowlist:
           - cmsis
           - cmsis_6
+          - fatfs
           - littlefs
-          - tinycrypt
+          - lvgl
           - mbedtls
-          - segger
-          - thrift
           - mcuboot
           - nanopb
-          - lvgl
+          - segger
+          - thrift
+          - tinycrypt
         path-allowlist:
           - modules/hal/*