Skip to content

Commit 6b71e2b

Browse files
committed
Simplify workflow code
Previously, a "block scalar" was used in the workflow. This is useful in the case of a multi-line string. However, this string is only a single line. Although it would be useful to break the command up into multiple lines via the use of the line continuation operators, this is not possible due to a quirk of the action. So the use of the "block scalar" is not really beneficial in this case. Furthermore, the use of the "block scalar" might encourage the maintainer to try to split the command into multiple lines as is common practice for complex shell commands in the infrastructure, leading to wasted time.
1 parent d18612c commit 6b71e2b

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

.github/workflows/check-shell-task.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,7 @@ jobs:
127127
linters: gcc
128128
# Due to a quirk of the "liskin/gh-problem-matcher-wrap" action, the entire command must be on a single line
129129
# (instead of being broken into multiple lines for readability).
130-
run: |
131-
task --silent shell:check SCRIPT_PATH="${{ matrix.script }}" SHELLCHECK_FORMAT=${{ matrix.configuration.format }}
130+
run: task --silent shell:check SCRIPT_PATH="${{ matrix.script }}" SHELLCHECK_FORMAT=${{ matrix.configuration.format }}
132131

133132
formatting:
134133
name: formatting (${{ matrix.script }})

0 commit comments

Comments
 (0)