Apply suggestions from code review

Co-authored-by: Kamil Śliwak <[email protected]>

Author: matheusaaguiar

Changelog.md

@@ -5,11 +5,11 @@ Language Features:
 
 Compiler Features:
 * ethdebug: Experimental support for instructions and source locations under EOF.
-* DocString Parser: Deprecation of inline assembly special comment `memory-safe-assembly`.
-* Syntax Checker: Deprecation of ABI coder v1.
-* Syntax Checker: Deprecation of `virtual` modifiers.
-* Type Checker: Deprecation of `send` and `transfer` functions on instances of `address`.
-* Type Checker: Deprecation of comparisons between `contract`-typed variables.
+* DocString Parser: Warn about deprecation of inline assembly special comment `memory-safe-assembly`.
+* Syntax Checker: Warn about deprecation of ABI coder v1.
+* Syntax Checker: Warn about deprecation of virtual modifiers.
+* Type Checker: Warn about deprecation of `send` and `transfer` functions on instances of `address`.
+* Type Checker: Warn about deprecation of comparisons between variables of contract types.
 
 Bugfixes:
 * Assembler: Fix not using a fixed-width type for IDs being assigned to subassemblies nested more than one level away, resulting in inconsistent `--asm-json` output between target architectures.

docs/assembly.rst

@@ -382,8 +382,7 @@ of Solidity, you can use a special comment to annotate an assembly block as memo
     }
 
 .. warning::
-    The ``memory-safe-assembly`` special comment is deprecated and scheduled for
-    removal in the next breaking version (0.9).
+    The ``memory-safe-assembly`` special comment is deprecated and scheduled for removal.
     For new code targeting recent compilers, specify the assembly block annotation.
 
 Advanced Safe Use of Memory

docs/control-structures.rst

@@ -700,10 +700,8 @@ and ``assert`` for internal error checking.
             uint balanceBeforeTransfer = address(this).balance;
             (bool success, ) = addr.call{value: msg.value / 2}("");
             require(success);
-            // Since require will stop execution and
-            // revert if success is false,
-            // there should be no way for us to
-            // still have half of the Ether.
+            // Since require will stop execution and revert if success is false,
+            // there should be no way for us to still have half of the Ether.
             assert(address(this).balance == balanceBeforeTransfer - msg.value / 2);
             return address(this).balance;
         }

libsolidity/analysis/DocStringTagParser.cpp

@@ -215,7 +215,7 @@ bool DocStringTagParser::visit(InlineAssembly const& _assembly)
 							2424_error,
 							_assembly.location(),
 							"Natspec 'memory-safe-assembly' special comment for inline assembly is deprecated and scheduled for removal in the next breaking version (0.9). "
-							"Instead, specify the assembly block annotation."
+							"Use the memory-safe block annotation instead."
 						);
 					}
 					else

libsolidity/analysis/SyntaxChecker.cpp

@@ -150,7 +150,7 @@ bool SyntaxChecker::visit(PragmaDirective const& _pragma)
 		else
 			m_sourceUnit->annotation().useABICoderV2 = (_pragma.literals()[1] == "v2");
 
-		if (_pragma.literals().size() > 1 && _pragma.literals()[1] == "v1")
+		if (!m_sourceUnit->annotation().useABICoderV2)
 			m_errorReporter.warning(
 				9511_error,
 				_pragma.location(),

libsolidity/analysis/TypeChecker.cpp

@@ -3233,7 +3233,7 @@ bool TypeChecker::visit(MemberAccess const& _memberAccess)
 				_memberAccess.location(),
 				fmt::format(
 					"'{}' is deprecated and scheduled for removal in the next breaking version (0.9). "
-					"Use 'call{{value: <amount>}}()' instead.",
+					"Use 'call{{value: <amount>}}(\"\")' instead.",
 					funType->kind() == FunctionType::Kind::Send ? "send" : "transfer"
 				)
 			);