Add Type 2 GSUB support for font freezing #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Problem: - The ss04 "Simplified i" feature uses a Type 2 substitution rule in the font (maps i → ['i.simple']) - opentype-feature-freezer lib only understood Type 1 substitution rules - When it encountered Type 2 rules, it silently skipped them - so customizations like ss04 never got applied to the generated fonts # Solution: - Remove opentype-feature-freezer dependency (doesn't support Type 2) - Create fontfreeze_activation.py (custom feature freezing script adapted from https://github.com/MuTsunTsai/fontfreeze) - Extended it to detect and process Type 2 substitution rules - Now when ss04 is enabled, it correctly freezes i → i.simple into the font's character map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4
Problem:
Solution: