Clear the resolver cache on each build (#894)

Author: benjervis

.changeset/wild-ducks-attend.md

@@ -0,0 +1,5 @@
+---
+'@atlaspack/rust': patch
+---
+
+Add an `on_new_build` hook to the ResolverPlugin trait, which allows us to clear the resolver cache between builds. This allows for the discovery of previously non-existent assets on the next incremental build.

crates/atlaspack/src/atlaspack.rs

@@ -158,6 +158,11 @@ impl Atlaspack {
 impl Atlaspack {
   pub fn build_asset_graph(&self) -> anyhow::Result<(Arc<AssetGraph>, bool)> {
     self.runtime.block_on(async move {
+      // Notify all resolver plugins that a new build is starting
+      for resolver in self.plugins.resolvers()? {
+        resolver.on_new_build();
+      }
+
       let mut request_tracker = self.request_tracker.write().await;
 
       let prev_asset_graph = request_tracker

crates/atlaspack_core/src/plugin/resolver_plugin.rs

@@ -87,6 +87,9 @@ pub trait ResolverPlugin: Any + Debug + Send + Sync {
   }
   /// Determines what the dependency specifier resolves to
   async fn resolve(&self, ctx: ResolveContext) -> Result<Resolved, anyhow::Error>;
+
+  /// Called when a new build is started. No-op by default.
+  fn on_new_build(&self) {}
 }
 
 #[cfg(test)]

crates/atlaspack_plugin_resolver/src/atlaspack_resolver.rs

@@ -454,6 +454,10 @@ impl ResolverPlugin for AtlaspackResolver {
       }),
     }
   }
+
+  fn on_new_build(&self) {
+    self.cache.clear();
+  }
 }
 
 fn should_include_node_module(include_node_modules: &IncludeNodeModules, name: &str) -> bool {

crates/atlaspack_shared_map/src/lib.rs

@@ -53,6 +53,12 @@ where
     map.insert(key, value);
   }
 
+  pub fn clear(&self) {
+    let map_cell = self.inner.write();
+    let mut map = map_cell;
+    map.clear();
+  }
+
   pub fn len(&self) -> usize {
     let map_cell = self.inner.read();
     let map = map_cell;

packages/core/integration-tests/test/watcher.ts

@@ -468,12 +468,11 @@ describe('watcher', function () {
     ]);
   });
 
-  it.v2('should rebuild if a missing file is added', async function () {
+  it('should rebuild if a missing file is added', async function () {
     await outputFS.mkdirp(inputDir);
     await outputFS.writeFile(
       path.join(inputDir, '/index.js'),
       'import {other} from "./other";\nexport default other;',
-      {encoding: 'utf8'},
     );
 
     let b = bundler(path.join(inputDir, 'index.js'), {inputFS: overlayFS});
@@ -484,7 +483,6 @@ describe('watcher', function () {
     await outputFS.writeFile(
       path.join(inputDir, '/other.js'),
       'export const other = 2;',
-      {encoding: 'utf8'},
     );
 
     buildEvent = await getNextBuild(b);

packages/utils/node-resolver-rs/src/cache.rs

@@ -126,6 +126,15 @@ impl Cache {
     Ok(self.fs.canonicalize(path, &self.realpath_cache)?)
   }
 
+  pub fn clear(&self) {
+    self.packages.clear();
+    self.package_duplicates.clear();
+    self.tsconfigs.clear();
+    self.is_dir_cache.clear();
+    self.is_file_cache.clear();
+    self.realpath_cache.clear();
+  }
+
   /// Calling this method before resolving will enable the package deduplication feature.
   /// It does thos by hydrating the "package_duplicates" lookup. This can
   /// the the be used when resolving packages that are duplicates, where a duplicate is a package