Skip to content

Relaunch only failed test methods #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion META-INF/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,13 @@
<add-to-group group-id="RunMenu" anchor="last"/>
<keyboard-shortcut first-keystroke="alt shift V" keymap="$default"/>
</action>

<action id="RerunFailedTestsAction" class="org.atoum.intellij.plugin.atoum.actions.RerunFailedTestsAction" />
</actions>



<depends>com.jetbrains.php</depends>
<depends>com.intellij.modules.platform</depends>

</idea-plugin>
</idea-plugin>
19 changes: 19 additions & 0 deletions src/org/atoum/intellij/plugin/atoum/Utils.java
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package org.atoum.intellij.plugin.atoum;

import com.google.common.collect.Lists;
import com.intellij.openapi.editor.Document;
import com.intellij.openapi.fileEditor.FileDocumentManager;
import com.intellij.openapi.project.Project;
import com.intellij.psi.util.PsiTreeUtil;
import com.jetbrains.php.PhpIndex;
Expand Down Expand Up @@ -98,4 +100,21 @@ public static PhpClass getFirstClassFromFile(PhpFile phpFile) {
Collection<PhpClass> phpClasses = PsiTreeUtil.collectElementsOfType(phpFile, PhpClass.class);
return phpClasses.size() == 0 ? null : phpClasses.iterator().next();
}

public static void saveFiles(PhpClass currentTestClass, Project project) {
FileDocumentManager fileDocumentManager = FileDocumentManager.getInstance();

Document documentTestClass = fileDocumentManager.getDocument(currentTestClass.getContainingFile().getVirtualFile());
if (documentTestClass != null) {
fileDocumentManager.saveDocument(documentTestClass);
}

PhpClass currentTestedClass = Utils.locateTestedClass(project, currentTestClass);
if (currentTestedClass != null) {
Document documentTestedClass = fileDocumentManager.getDocument(currentTestedClass.getContainingFile().getVirtualFile());
if (documentTestedClass != null) {
fileDocumentManager.saveDocument(documentTestedClass);
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
package org.atoum.intellij.plugin.atoum.actions;

import com.intellij.execution.Location;
import com.intellij.execution.testframework.sm.runner.SMTestProxy;
import com.intellij.icons.AllIcons;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.Presentation;
import com.intellij.openapi.project.Project;
import com.intellij.psi.PsiElement;
import com.intellij.psi.search.GlobalSearchScope;
import com.jetbrains.php.lang.psi.PhpFile;
import com.jetbrains.php.lang.psi.elements.Method;
import com.jetbrains.php.lang.psi.elements.PhpClass;
import org.atoum.intellij.plugin.atoum.Utils;
import org.atoum.intellij.plugin.atoum.model.RunnerConfiguration;
import org.atoum.intellij.plugin.atoum.run.Runner;

public class RerunFailedTestsAction extends AnAction
{
private SMTestProxy.SMRootTestProxy tests;

// Action class must have a no argument constructor
public RerunFailedTestsAction() {
this.getTemplatePresentation().setText("Rerun Failed Tests");
this.getTemplatePresentation().setIcon(AllIcons.RunConfigurations.RerunFailedTests);
}

public RerunFailedTestsAction(SMTestProxy.SMRootTestProxy tests)
{
this();
this.tests = tests;
}

@Override
public void update(AnActionEvent e) {
Presentation presentation = e.getPresentation();
presentation.setEnabled(false);
presentation.setVisible(true);

if (!this.tests.isInProgress() && !this.tests.isPassed()) {
presentation.setEnabled(true);
}
}

@Override
public void actionPerformed(AnActionEvent anActionEvent)
{
RunnerConfiguration runConfiguration = new RunnerConfiguration();
Project project = getEventProject(anActionEvent);

for (SMTestProxy methodProxy: tests.getAllTests()) {
if (!methodProxy.isPassed()) {
Location loc = methodProxy.getLocation(project, GlobalSearchScope.EMPTY_SCOPE);

if (loc == null) {
continue;
}

PsiElement elem = loc.getPsiElement();

if (elem instanceof PhpClass) {
Utils.saveFiles((PhpClass) elem, project);
runConfiguration.setFile((PhpFile)elem.getContainingFile());
continue;
}

while (elem != null && !(elem instanceof Method)) {
elem = elem.getParent();
}

if (elem != null) {
runConfiguration.addMethod((Method) elem);
}
}
}

Runner runner = new Runner(project);
runner.run(runConfiguration);
}
}
23 changes: 2 additions & 21 deletions src/org/atoum/intellij/plugin/atoum/actions/Run.java
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
import com.intellij.openapi.actionSystem.AnActionEvent;
import com.intellij.openapi.actionSystem.PlatformDataKeys;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.editor.Document;
import com.intellij.openapi.fileEditor.FileDocumentManager;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.psi.PsiElement;
import com.jetbrains.php.lang.psi.PhpFile;
Expand Down Expand Up @@ -42,23 +40,6 @@ public void update(AnActionEvent event) {
}
}

protected void saveFiles(PhpClass currentTestClass, Project project) {
FileDocumentManager fileDocumentManager = FileDocumentManager.getInstance();

Document documentTestClass = fileDocumentManager.getDocument(currentTestClass.getContainingFile().getVirtualFile());
if (documentTestClass != null) {
fileDocumentManager.saveDocument(documentTestClass);
}

PhpClass currentTestedClass = Utils.locateTestedClass(project, currentTestClass);
if (currentTestedClass != null) {
Document documentTestedClass = fileDocumentManager.getDocument(currentTestedClass.getContainingFile().getVirtualFile());
if (documentTestedClass != null) {
fileDocumentManager.saveDocument(documentTestedClass);
}
}
}

public void actionPerformed(final AnActionEvent e) {
PhpClass currentTestClass = getCurrentTestClass(e);
VirtualFile selectedDir = null;
Expand All @@ -73,12 +54,12 @@ public void actionPerformed(final AnActionEvent e) {

RunnerConfiguration runConfiguration = new RunnerConfiguration();
if (null != currentTestClass) {
saveFiles(currentTestClass, project);
Utils.saveFiles(currentTestClass, project);
runConfiguration.setFile((PhpFile)currentTestClass.getContainingFile());

Method currentTestMethod = getCurrentTestMethod(e);
if (currentTestMethod != null) {
runConfiguration.setMethod(currentTestMethod);
runConfiguration.addMethod(currentTestMethod);
}
}

Expand Down
9 changes: 8 additions & 1 deletion src/org/atoum/intellij/plugin/atoum/model/MethodResult.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ public class MethodResult {

protected String name;
protected String content;
protected Integer failLineNumber;

public MethodResult(String name, String content) {
public MethodResult(String name, String content, Integer failLineNumber) {
this.name = name;
this.content = content;
this.failLineNumber = failLineNumber;
}

public void definedStatePassed() {
Expand Down Expand Up @@ -42,4 +44,9 @@ public String getState()
{
return this.state;
}

public Integer getFailLineNumber()
{
return this.failLineNumber;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,16 @@
import com.jetbrains.php.lang.psi.PhpFile;
import com.jetbrains.php.lang.psi.elements.Method;

import java.util.ArrayList;
import java.util.List;

public class RunnerConfiguration {

protected PhpFile file;

protected VirtualFile directory;

protected Method method;
protected List<Method> methods = new ArrayList<>();

public PhpFile getFile () {
return file;
Expand All @@ -28,11 +31,11 @@ public void setDirectory(VirtualFile directory) {
this.directory = directory;
}

public void setMethod(Method method) {
this.method = method;
public void addMethod(Method method) {
this.methods.add(method);
}

public Method getMethod () {
return method;
public List<Method> getMethods () {
return methods;
}
}
20 changes: 14 additions & 6 deletions src/org/atoum/intellij/plugin/atoum/model/TestsResultFactory.java
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ public static TestsResult createFromTapOutput(String tapOutput)
Pattern statusLinePattern = Pattern.compile("((?:not )?ok) (\\d+)(?: (?:# SKIP|# TODO|-) (.+)::(.+)\\(\\))?$");
Pattern nameLinePattern = Pattern.compile("^# ([\\w\\\\]+)::(.+)\\(\\)$");
Pattern planLinePattern = Pattern.compile("^\\d+\\.\\.\\d+$");
Pattern failLocationPattern = Pattern.compile("^# .+:([0-9]+)$");

String[] tapOutputLines = tapOutput.split("\n");

Expand All @@ -21,6 +22,7 @@ public static TestsResult createFromTapOutput(String tapOutput)
String currentContent = "";
String currentClassname = "";
String currentStatus = "";
Integer currentLineNumber = null;

for (Integer i = 0; i < tapOutputLines.length; i++) {
String currentLine = tapOutputLines[i];
Expand All @@ -33,35 +35,41 @@ public static TestsResult createFromTapOutput(String tapOutput)

if (statusLineMatcher.matches()) {
if (infosFound) {
flushLine(testsResult, currentClassname, currentMethodName, currentContent, currentStatus);
flushLine(testsResult, currentClassname, currentMethodName, currentContent, currentStatus, currentLineNumber);
}

currentMethodName = statusLineMatcher.group(4);
currentContent = "";
currentClassname = statusLineMatcher.group(3);
currentStatus = statusLineMatcher.group(1);
currentLineNumber = null;
infosFound = true;

} else {
Matcher nameLineMatcher = nameLinePattern.matcher(currentLine);
if (nameLineMatcher.matches()) {
currentClassname = nameLineMatcher.group(1);
currentMethodName = nameLineMatcher.group(2);
} else if (currentLine.length() > 0) {
currentContent += currentLine.substring(1) + "\n";
} else {
Matcher failLocationMatcher = failLocationPattern.matcher(currentLine);
if (failLocationMatcher.matches()) {
currentLineNumber = Integer.parseInt(failLocationMatcher.group(1));
} else if (currentLine.length() > 0) {
currentContent += currentLine.substring(1) + "\n";
}
}
}
}

if (infosFound) {
flushLine(testsResult, currentClassname, currentMethodName, currentContent, currentStatus);
flushLine(testsResult, currentClassname, currentMethodName, currentContent, currentStatus, currentLineNumber);
}

return testsResult;
}

protected static void flushLine(TestsResult testsResult, String currentClassname, String currentMethodName, String currentContent, String currentStatus) {
MethodResult methodResult = new MethodResult(currentMethodName, currentContent);
protected static void flushLine(TestsResult testsResult, String currentClassname, String currentMethodName, String currentContent, String currentStatus, Integer lineNumber) {
MethodResult methodResult = new MethodResult(currentMethodName, currentContent, lineNumber);
if (!testsResult.hasClassResult(currentClassname)) {
ClassResult classResult = new ClassResult();
classResult.setName(currentClassname);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package org.atoum.intellij.plugin.atoum.run;

import com.jetbrains.php.config.interpreters.PhpConfigurationOptionData;
import com.jetbrains.php.lang.psi.elements.Method;
import org.atoum.intellij.plugin.atoum.model.RunnerConfiguration;

import java.io.File;
Expand Down Expand Up @@ -53,9 +54,9 @@ public CommandLineArgumentsBuilder useConfiguration(RunnerConfiguration runnerCo
this.commandLineArgs.add("-f");
this.commandLineArgs.add(this.relativizePath(runnerConfiguration.getFile().getVirtualFile().getPath()));
}
if (null != runnerConfiguration.getMethod()) {
for (Method method : runnerConfiguration.getMethods()) {
this.commandLineArgs.add("-m");
this.commandLineArgs.add("*::" + runnerConfiguration.getMethod().getName());
this.commandLineArgs.add("*::" + method.getName());
}

return this;
Expand Down
23 changes: 18 additions & 5 deletions src/org/atoum/intellij/plugin/atoum/run/Runner.java
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,17 @@
import com.intellij.notification.Notification;
import com.intellij.notification.NotificationType;
import com.intellij.notification.Notifications;
import com.intellij.openapi.actionSystem.ActionManager;
import com.intellij.openapi.actionSystem.ActionToolbar;
import com.intellij.openapi.actionSystem.DefaultActionGroup;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.ui.SimpleToolWindowPanel;
import com.intellij.openapi.util.Disposer;
import com.intellij.openapi.util.Key;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.openapi.wm.ToolWindow;
import com.intellij.openapi.wm.ToolWindowAnchor;
import com.intellij.openapi.wm.ToolWindowManager;
import com.intellij.psi.PsiDirectory;
import com.intellij.ui.content.Content;
import com.intellij.ui.content.ContentManager;
import com.jetbrains.php.config.PhpProjectConfigurationFacade;
Expand All @@ -34,6 +37,7 @@
import com.jetbrains.php.run.PhpRunConfiguration;
import com.jetbrains.php.run.PhpRunConfigurationFactoryBase;
import org.atoum.intellij.plugin.atoum.AtoumUtils;
import org.atoum.intellij.plugin.atoum.actions.RerunFailedTestsAction;
import org.atoum.intellij.plugin.atoum.model.*;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
Expand Down Expand Up @@ -137,14 +141,23 @@ public RunConfiguration createTemplateConfiguration(Project project) {
commandLineBuilder.useConfigFile(phpstormConfigFile);
}

ActionManager am = ActionManager.getInstance();
DefaultActionGroup buttonGroup = new DefaultActionGroup();
ActionToolbar viewToolbar = am.createActionToolbar("atoum.ConsoleToolbar", buttonGroup, false);

SimpleToolWindowPanel toolWindowPanel = new SimpleToolWindowPanel(false, true);
toolWindowPanel.setContent(testsOutputConsoleView.getComponent());
toolWindowPanel.setToolbar(viewToolbar.getComponent());

ContentManager contentManager = toolWindow.getContentManager();
Content myContent;
myContent = toolWindow.getContentManager().getFactory().createContent(testsOutputConsoleView.getComponent(), "tests results", false);
toolWindow.getContentManager().removeAllContents(true);
toolWindow.getContentManager().addContent(myContent);
Content myContent = contentManager.getFactory().createContent(toolWindowPanel.getComponent(), "tests results", false);
contentManager.removeAllContents(true);
contentManager.addContent(myContent);

final SMTRunnerConsoleView console = (SMTRunnerConsoleView)testsOutputConsoleView;

buttonGroup.add(new RerunFailedTestsAction(console.getResultsViewer().getTestsRootNode()));

String[] commandLineArgs = commandLineBuilder.build();

HashMap environnmentVariables = new HashMap();
Expand Down
Loading