Skip to content

Commit 841f199

Browse files
committed
fileinformer: update usages for fsnotify
1 parent 94dd9ad commit 841f199

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

fileinformer/file_informer.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -250,24 +250,22 @@ func (f *FileSharedIndexInformer) Run(stopCh <-chan struct{}) {
250250
continue
251251
}
252252
f.log.V(4).Info("filewatcher got event", "event", event.String(), "event_name", event.Name)
253-
if event.Op&fsnotify.Write == fsnotify.Write ||
254-
event.Op&fsnotify.Create == fsnotify.Create {
253+
if event.Has(fsnotify.Write) || event.Has(fsnotify.Create) {
255254
f.RLock()
256255
for _, h := range f.handlers {
257256
h.OnAdd(fileName)
258257
}
259258
f.RUnlock()
260259
}
261260
// chmod is the event from a configmap reload in kube
262-
if event.Op&fsnotify.Rename == fsnotify.Rename ||
263-
event.Op&fsnotify.Chmod == fsnotify.Chmod {
261+
if event.Has(fsnotify.Rename) || event.Has(fsnotify.Chmod) {
264262
f.RLock()
265263
for _, h := range f.handlers {
266264
h.OnUpdate(fileName, fileName)
267265
}
268266
f.RUnlock()
269267
}
270-
if event.Op&fsnotify.Remove == fsnotify.Remove {
268+
if event.Has(fsnotify.Remove) {
271269
f.RLock()
272270
for _, h := range f.handlers {
273271
h.OnDelete(fileName)

fileinformer/file_informer_test.go

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,15 @@ func TestFileInformer(t *testing.T) {
7777
require.Eventually(t, func() bool {
7878
eventHandlers.Lock()
7979
defer eventHandlers.Unlock()
80-
return len(eventHandlers.Calls) == 4
81-
}, 5000*time.Millisecond, 100*time.Millisecond)
80+
81+
foundDelete := false
82+
for _, call := range eventHandlers.Calls {
83+
if call.Method == "OnDelete" {
84+
foundDelete = true
85+
}
86+
}
87+
return foundDelete
88+
}, 500*time.Millisecond, 10*time.Millisecond)
8289

8390
cancel()
8491

0 commit comments

Comments
 (0)