Some parts don't define signature bytes

[stefanrueger]

The following mcus don't seem to define signature bytes.

  at43usb320
  at43usb355
  at76c711
  at90c8534
  at90pwm1
  at90pwm2
  at90pwm3
  at90s2333
  at90usb82
  at94k
  atmega32hvbrevb
  atmega8hva
  m3000

Some of these can be sourced as follows:

  at90pwm1   => [0x1E, 0x93, 0x83], # [1]
  at90pwm2   => [0x1E, 0x93, 0x81], # /usr/local/etc/avrdude.conf 9935     
  at90pwm3   => [0x1E, 0x93, 0x81], # /usr/local/etc/avrdude.conf 10118   
  at90s2333  => [0x1E, 0x91, 0x05], # /usr/local/etc/avrdude.conf 2331     
  at90usb82  => [0x1E, 0x93, 0x82], # /usr/local/etc/avrdude.conf 13273
  atmega8hva => [0x1E, 0x93, 0x10], # [2]

[1] Datasheet AT90PWM1
[2] Datasheet ATmega8HVA

[stefanrueger]

And, also

atmega32hvbrevb => [0x1E, 0x94, 0x0D], # [1]
atmega8hva      => [0x1E, 0x93, 0x10], # [1] in correspondence with the data sheet

[1] from Atmel-Studio's .atdf file in the corresponding DFP pack

It's possible (likely?) that the iom file for parts with missing signatures have other deficiencies, too. For example, the ATmega32HVBrevB has SPM_PAGESIZE defined as 64, but the .atdf file file thinks it's 128. And gcc-avr ought to #define __AVR_ATmega32HVBrevB__ rather than __AVR_ATmega32HVBREVB__.

[sprintersb]

The atmega32hvbrevb sigs differ from 0x1E, 0x94, 0x0D as mentioned in #878 (comment):

diff --git a/include/avr/iom32hvbrevb.h b/include/avr/iom32hvbrevb.h
index 3eb976ff..640b94e1 100644
--- a/include/avr/iom32hvbrevb.h
+++ b/include/avr/iom32hvbrevb.h
@@ -950,4 +950,8 @@
 #define SLEEP_MODE_PWR_OFF (0x04<<1)
 
 
+#define SIGNATURE_0 0x1E
+#define SIGNATURE_1 0x95
+#define SIGNATURE_2 0x10
+
 #endif  /* _AVR_IOM32HVBREVB_H_ */

What I did

Run

#!/bin/bash

# at90s2333 at94k atmega8hva atmega32hvbrevb at76c711 at90usb82
hs="io2333.h ioat94k.h iom8hva.h iom32hvbrevb.h io76c711.h iousb82.h"

t0='#define SIGNATURE_0 0xcafe'
t1='#define SIGNATURE_1 0xcafe'
t2='#define SIGNATURE_2 0xcafe'

for x in $hs; do
    h=include/avr/$x
    echo "== $h"

    if grep "SIGNATURE_" $h; then
	echo "== HAS SIG"
	continue
    fi

    # Find a loc to insert.
    if grep -n '#endif.*_H_' $h > loc.txt; then
	echo '== found'
	cat loc.txt
	loc=$(cat loc.txt | cut -d ':' -f 1)
	sed -i -e "${loc}i${t0}\n${t1}\n${t2}\n" $h
    fi
done

This inserts phony 0xcafe signatures.

Then fix these with devtools/signats.sh which gets signatures from avrdude.conf.in of from atdf.

[sprintersb]

...so now we have this:

include/avr/iom32hvb.h-#define SIGNATURE_0 0x1E
include/avr/iom32hvb.h-#define SIGNATURE_1 0x95
include/avr/iom32hvb.h:#define SIGNATURE_2 0x10
-
include/avr/iom32hvbrevb.h-#define SIGNATURE_0 0x1E
include/avr/iom32hvbrevb.h-#define SIGNATURE_1 0x95
include/avr/iom32hvbrevb.h:#define SIGNATURE_2 0x10

iom32hvbrevb.h's are from atdf; avrdude doesn't have that device.

[sprintersb]

The list of devices without signature is down to:

• at94k, at90c8534, m3000, at76c711, at43usb355, at43usb320
  Their signatures are elusive.