Add fips option #602
Open
Add fips option #602
+30,450
−40,241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add use-fips-endpoint input to actions.yml and index.js - Assemble ECR config once and pass it to wrapper functions - Add use-fips-endpoint input to existing tests
|
@arjraman, not sure who to tag for these, but who would review this? Would be super helpful 👍🏻 |
|
we would love this as well - bump! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#401
Description of changes:
Adds an optional
use-fips-endpointinput. If this input is set to true, the ECR client configuration will includeuseFipsEndpoint: true(allowing authentication token generation and docker login to theecr-fipsvariant of the ECR registry).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.