add note about removing withResolvers utility whne we drop support for Node 20

svozza · svozza · commit 50c1ebb8b267 · 2025-10-18T19:43:41.000+01:00
diff --git a/packages/metrics/tests/unit/helpers.ts b/packages/metrics/tests/unit/helpers.ts
@@ -12,6 +12,10 @@ type Invocation = {
  * a more convenient way to create promises that can be resolved or rejected from
  * outside the Promise constructor.
  *
+ * We need this polyfill because this function is not available in Node 20. When we drop
+ * support for this version of Node, then we should remove this function and use the
+ * inbuilt `Promise.withResolvers` static methods.
+ *
  * @returns Object containing the promise and its resolve/reject functions
  *
  * @example

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,10 @@ type Invocation = {`
`12`	`12`	`* a more convenient way to create promises that can be resolved or rejected from`
`13`	`13`	`* outside the Promise constructor.`
`14`	`14`	`*`
	`15`	`+ * We need this polyfill because this function is not available in Node 20. When we drop`
	`16`	`+ * support for this version of Node, then we should remove this function and use the`
	`17`	+ * inbuilt `Promise.withResolvers` static methods.
	`18`	`+ *`
`15`	`19`	`* @returns Object containing the promise and its resolve/reject functions`
`16`	`20`	`*`
`17`	`21`	`* @example`