fix(lambda): add token resolution validation to capacity providers #36275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
requested changes
Dec 2, 2025
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
Contributor
|
@reedham-aws Can we have some unit tests that cover the edge of these properties being provided as tokens instead of exact values ? |
kumvprat
reviewed
Dec 8, 2025
| new lambda.CapacityProvider(stack, 'MyCapacityProvider', { | ||
| capacityProviderName: tokenName, | ||
| maxVCpuCount: cdk.Token.asNumber(tokenMaxVCpu), | ||
| subnets: tokenSubnets.map((id, i) => ec2.Subnet.fromSubnetId(stack, `TokenSubnet${i}`, id)), |
Contributor
There was a problem hiding this comment.
Is it possible to have assertions on subnets and securityGroups values in the checks below ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
N/a
Reason for this change
Current validation of fields for recent capacity provider additions in
aws-lambdadoes not take into account unresolved tokens.Description of changes
Added
Token.isUnresolved()checks before all new validations. This ensures that validation only occurs when concrete values are provided, while still allowing tokens to pass through for CloudFormation resolution.Describe any new or updated permissions being added
N/a
Description of how you validated changes
Changes should be only internal, validated that unit and integration tests continued to work.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license