Add fast-fail unit tests and diagnostics method

Author: aj-aws

lib/instance_agent/plugins/codedeploy/command_poller.rb

@@ -255,6 +255,16 @@ def gather_diagnostics_from_error(error)
           gather_diagnostics_from_script_error(script_error)
         end
 
+        private
+        def gather_diagnostics_from_failure_after_restart(msg = "")
+          begin
+            raise ScriptError.new(ScriptError::FAILED_AFTER_RESTART_CODE, "", ScriptLog.new), "Failed: #{msg}"
+          rescue ScriptError => e
+            script_error = e
+          end
+          gather_diagnostics_from_script_error(script_error)
+        end
+
         private
         def gather_diagnostics(msg = "")
           begin

test/instance_agent/plugins/codedeploy/command_poller_test.rb

@@ -410,6 +410,43 @@ def get_ack_diagnostics(is_command_noop)
 
       end
 
+      context 'calling recover_from_crash when a lifecycle event is in-progress' do
+
+        setup do
+          InstanceAgent::Plugins::CodeDeployPlugin::DeploymentCommandTracker.stubs(:check_deployment_event_inprogress?).returns(true)
+          InstanceAgent::Plugins::CodeDeployPlugin::DeploymentCommandTracker.stubs(:deployment_dir_path).returns("deployment-path")
+          InstanceAgent::Plugins::CodeDeployPlugin::DeploymentCommandTracker.stubs(:most_recent_host_command_identifier).returns("i-123")
+          InstanceAgent::Plugins::CodeDeployPlugin::DeploymentCommandTracker.stubs(:clean_ongoing_deployment_dir)
+        end
+
+        should 'call PutHostCommandComplete' do
+          @deploy_control_client.expects(:put_host_command_complete).
+            with(:command_status => "Failed",
+                 :diagnostics => {:format => "JSON", :payload => gather_diagnostics_from_failure_after_restart("", "Failing in-progress lifecycle event after an agent restart.")},
+                 :host_command_identifier => "i-123")
+
+          @poller.recover_from_crash?
+        end
+      end
+
+      context 'calling recover_from_crash when a lifecycle event is not in-progress' do
+
+        setup do
+          InstanceAgent::Plugins::CodeDeployPlugin::DeploymentCommandTracker.stubs(:check_deployment_event_inprogress?).returns(false)
+          InstanceAgent::Plugins::CodeDeployPlugin::DeploymentCommandTracker.stubs(:deployment_dir_path).returns("deployment-path")
+          InstanceAgent::Plugins::CodeDeployPlugin::DeploymentCommandTracker.stubs(:most_recent_host_command_identifier).returns("i-123")
+          InstanceAgent::Plugins::CodeDeployPlugin::DeploymentCommandTracker.stubs(:clean_ongoing_deployment_dir)
+        end
+
+        should 'not call PutHostCommandComplete' do
+          @put_host_command_complete_state.become('never')
+          @deploy_control_client.expects(:put_host_command_complete).never.
+            when(@put_host_command_complete_state.is('never'))
+
+          @poller.recover_from_crash?
+        end
+      end
+
       context 'when no deployment specification is given by GetDeploymentSpecification' do
 
         setup do
@@ -447,7 +484,7 @@ def get_ack_diagnostics(is_command_noop)
 
       should 'allow exceptions from execute_command to propagate to caller' do
         @executor.expects(:execute_command).
-          raises("some error") 
+          raises("some error")
         @deploy_control_client.expects(:put_host_command_complete).
           with(:command_status => "Failed",
                :diagnostics => {:format => "JSON", :payload => gather_diagnostics_from_error(RuntimeError.new("some error"))},