Skip to content

Commit b347469

Browse files
authored
Add back deprecated flags for checking whether an instance is managed by NTH (#686)
We removed these flags in NTH release v1.17.0, but they are still supported for now. The Helm chart should support both in the mean time.
1 parent 7547519 commit b347469

File tree

2 files changed

+12
-0
lines changed

2 files changed

+12
-0
lines changed

config/helm/aws-node-termination-handler/templates/deployment.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,14 @@ spec:
8282
value: {{ .Values.enablePrometheusServer | quote }}
8383
- name: PROMETHEUS_SERVER_PORT
8484
value: {{ .Values.prometheusServerPort | quote }}
85+
# [DEPRECATED] Use CHECK_TAG_BEFORE_DRAINING instead
86+
- name: CHECK_ASG_TAG_BEFORE_DRAINING
87+
value: {{ .Values.checkASGTagBeforeDraining | quote }}
8588
- name: CHECK_TAG_BEFORE_DRAINING
8689
value: {{ .Values.checkTagBeforeDraining | quote }}
90+
# [DEPRECATED] Use MANAGED_TAG instead
91+
- name: MANAGED_ASG_TAG
92+
value: {{ .Values.managedAsgTag | quote }}
8793
- name: MANAGED_TAG
8894
value: {{ .Values.managedTag | quote }}
8995
- name: USE_PROVIDER_ID

config/helm/aws-node-termination-handler/values.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,9 +173,15 @@ queueURL: ""
173173
# The maximum amount of parallel event processors to handle concurrent events
174174
workers: 10
175175

176+
# [DEPRECATED] Use checkTagBeforeDraining instead
177+
checkASGTagBeforeDraining: true
178+
176179
# If true, check that the instance is tagged with "aws-node-termination-handler/managed" as the key before draining the node
177180
checkTagBeforeDraining: true
178181

182+
# [DEPRECATED] Use managedTag instead
183+
managedAsgTag: "aws-node-termination-handler/managed"
184+
179185
# The tag to ensure is on a node if checkTagBeforeDraining is true
180186
managedTag: "aws-node-termination-handler/managed"
181187

0 commit comments

Comments
 (0)