From 0493683f3311e1d5c9ca95308a9df8420d4bf3e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Merlin=20B=C3=B6gershausen?= Date: Mon, 22 Sep 2025 15:09:38 +0200 Subject: [PATCH 1/2] add missing ')' to OpenRewrite Mathod Matcher --- .../amazon/awssdk/v2migration/S3AddImportsAndComments.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java b/v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java index 6f14bbeadb77..3004c5f66e41 100644 --- a/v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java +++ b/v2-migration/src/main/java/software/amazon/awssdk/v2migration/S3AddImportsAndComments.java @@ -39,7 +39,7 @@ public class S3AddImportsAndComments extends Recipe { private static final MethodMatcher CREATE_BUCKET = v1S3MethodMatcher("createBucket(String, " - + V1_S3_MODEL_PKG + "Region"); + + V1_S3_MODEL_PKG + "Region)"); private static final MethodMatcher LIST_NEXT_BATCH_OBJECTS = v1S3MethodMatcher("listNextBatchOfObjects(..)"); private static final MethodMatcher LIST_NEXT_BATCH_VERSIONS = v1S3MethodMatcher("listNextBatchOfVersions(..)"); private static final MethodMatcher GET_METADATA = v1S3MethodMatcher("getCachedResponseMetadata(..)"); From 7afa63f89583ea9372eee24c6cf581fa5869dc72 Mon Sep 17 00:00:00 2001 From: hdavidh Date: Tue, 23 Sep 2025 13:39:33 -0700 Subject: [PATCH 2/2] add missing ')' to OpenRewrite Method Matcher --- .../bugfix-AWSSDKforJavav2MigrationTool-8cf1e83.json | 6 ++++++ .../awssdk/v2migration/TransferManagerMethodsToV2.java | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .changes/next-release/bugfix-AWSSDKforJavav2MigrationTool-8cf1e83.json diff --git a/.changes/next-release/bugfix-AWSSDKforJavav2MigrationTool-8cf1e83.json b/.changes/next-release/bugfix-AWSSDKforJavav2MigrationTool-8cf1e83.json new file mode 100644 index 000000000000..354a8a0671f9 --- /dev/null +++ b/.changes/next-release/bugfix-AWSSDKforJavav2MigrationTool-8cf1e83.json @@ -0,0 +1,6 @@ +{ + "type": "bugfix", + "category": "AWS SDK for Java v2 Migration Tool", + "contributor": "MBoegers", + "description": "Fix OpenRewrite recipe MethodMatcher" +} diff --git a/v2-migration/src/main/java/software/amazon/awssdk/v2migration/TransferManagerMethodsToV2.java b/v2-migration/src/main/java/software/amazon/awssdk/v2migration/TransferManagerMethodsToV2.java index c97a83125791..d9a7948bd619 100644 --- a/v2-migration/src/main/java/software/amazon/awssdk/v2migration/TransferManagerMethodsToV2.java +++ b/v2-migration/src/main/java/software/amazon/awssdk/v2migration/TransferManagerMethodsToV2.java @@ -51,7 +51,7 @@ public class TransferManagerMethodsToV2 extends Recipe { private static final MethodMatcher COPY_REQUEST = v2TmMethodMatcher(String.format("copy(%sCopyObjectRequest)", V2_S3_MODEL_PKG)); private static final MethodMatcher COPY_BUCKET_KEY = - v2TmMethodMatcher("copy(String, String, String, String"); + v2TmMethodMatcher("copy(String, String, String, String)"); private static final MethodMatcher DOWNLOAD_DIR = v2TmMethodMatcher("downloadDirectory(String, String, java.io.File)");