Skip to content

Commit 5275bbd

Browse files
committed
refactor: remove unused files per PR feedback
1 parent 8f8962b commit 5275bbd

File tree

5 files changed

+24
-195
lines changed

5 files changed

+24
-195
lines changed

sdk/src/Core/Amazon.Runtime/ClientConfigExtensions.cs

Lines changed: 0 additions & 103 deletions
This file was deleted.

sdk/src/Core/Amazon.Runtime/IAuthSchemeResolver.cs

Lines changed: 0 additions & 39 deletions
This file was deleted.

sdk/src/Core/Amazon.Runtime/IClientConfig.cs

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -398,6 +398,28 @@ public partial interface IClientConfig
398398
/// </summary>
399399
ResponseChecksumValidation ResponseChecksumValidation { get; }
400400

401+
/// <summary>
402+
/// Gets or sets the authentication scheme preference for this client configuration.
403+
/// <para>
404+
/// This property allows you to specify a comma-separated preference list of authentication schemes
405+
/// (e.g., "sigv4a,sigv4") that will be used to reprioritize the supported authentication schemes for this client.
406+
/// If not set, the client will use environment variables, configuration files,
407+
/// or fall back to the default model-based authentication scheme resolution.
408+
/// </para>
409+
/// </summary>
410+
string AuthSchemePreference { get; }
411+
412+
/// <summary>
413+
/// Gets or sets the SigV4a signing region set for this client.
414+
/// <para>
415+
/// This property allows you to specify a comma-separated list of regions (e.g., "us-east-1,us-west-2")
416+
/// that will be used for SigV4a signing. The region set determines which regions the signed request is valid for.
417+
/// If not set, the client will use environment variables, configuration files,
418+
/// endpoints metadata, or fall back to the client's configured region.
419+
/// </para>
420+
/// </summary>
421+
string SigV4aSigningRegionSet { get; }
422+
401423

402424

403425
/// <summary>

sdk/src/Core/Amazon.Runtime/Internal/Util/SafeConfigurationResolver.cs

Lines changed: 0 additions & 51 deletions
This file was deleted.

sdk/src/Core/Amazon.Runtime/Pipeline/Handlers/BaseAuthResolverHandler.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ protected virtual List<IAuthSchemeOption> ApplyAuthSchemePreferences(IClientConf
364364
private string ResolveAuthSchemePreference(IClientConfig clientConfig)
365365
{
366366
// Check for legacy SignatureMethod configuration (backwards compatibility for S3)
367-
if (clientConfig?.SignatureMethod != null && clientConfig.GetIsSignatureMethodExplicitlySet())
367+
if (clientConfig?.SignatureMethod != null && (clientConfig as ClientConfig)?.IsSignatureMethodExplicitlySet == true)
368368
{
369369
bool isS3Service = clientConfig.ServiceId?.Equals("S3", StringComparison.OrdinalIgnoreCase) == true ||
370370
clientConfig.ServiceId?.Equals("S3 Control", StringComparison.OrdinalIgnoreCase) == true;
@@ -383,7 +383,7 @@ private string ResolveAuthSchemePreference(IClientConfig clientConfig)
383383
}
384384

385385
// Client configuration
386-
string clientPreference = clientConfig?.GetAuthSchemePreference();
386+
string clientPreference = clientConfig?.AuthSchemePreference;
387387
if (!string.IsNullOrWhiteSpace(clientPreference))
388388
{
389389
Logger.InfoFormat("Using auth scheme preference from client configuration: {0}", clientPreference);

0 commit comments

Comments
 (0)