fix: remove dummy settings from unknown profiles and wrap sendGetMfaCode in lambda

Author: liramon1

server/aws-lsp-identity/src/language-server/identityServer.ts

@@ -11,6 +11,7 @@ import {
     PartialInitializeResult,
     ShowMessageRequestParams,
     GetIamCredentialParams,
+    GetMfaCodeParams,
 } from '@aws/language-server-runtimes/server-interface'
 import { SharedConfigProfileStore } from './profiles/sharedConfigProfileStore'
 import { IdentityService } from './identityService'
@@ -41,7 +42,8 @@ export class IdentityServer extends ServerBase {
         const showMessageRequest: ShowMessageRequest = (params: ShowMessageRequestParams) =>
             this.features.lsp.window.showMessageRequest(params)
         const showProgress: ShowProgress = this.features.lsp.sendProgress
-        const sendGetMfaCode: SendGetMfaCode = this.features.identityManagement.sendGetMfaCode
+        const sendGetMfaCode: SendGetMfaCode = (params: GetMfaCodeParams) =>
+            this.features.identityManagement.sendGetMfaCode(params)
 
         // Initialize dependencies
         const profileStore = new SharedConfigProfileStore(this.observability)

server/aws-lsp-identity/src/language-server/identityService.ts

@@ -181,7 +181,7 @@ export class IdentityService {
             emitMetric('Succeeded')
 
             return {
-                credential: { id: params.profileName, credentials: credentials },
+                credential: { id: params.profileName, kinds: profile.kinds, credentials: credentials },
                 updateCredentialsParams: { data: credentials, encrypted: false },
             }
         } catch (e) {

server/aws-lsp-identity/src/language-server/profiles/sharedConfigProfileStore.test.ts

@@ -99,9 +99,7 @@ describe('SharedConfigProfileStore', async () => {
                 {
                     kinds: [ProfileKind.Unknown],
                     name: 'subsettings',
-                    settings: {
-                        region: undefined,
-                    },
+                    settings: {},
                 },
                 {
                     kinds: [ProfileKind.SsoTokenProfile],
@@ -192,9 +190,7 @@ describe('SharedConfigProfileStore', async () => {
                     {
                         kinds: [ProfileKind.Unknown],
                         name: 'subsettings',
-                        settings: {
-                            region: undefined,
-                        },
+                        settings: {},
                     },
                     {
                         kinds: [ProfileKind.SsoTokenProfile],
@@ -290,9 +286,7 @@ describe('SharedConfigProfileStore', async () => {
                     {
                         kinds: [ProfileKind.Unknown],
                         name: 'subsettings',
-                        settings: {
-                            region: undefined,
-                        },
+                        settings: {},
                     },
                     {
                         kinds: ['SsoTokenProfile'],
@@ -440,9 +434,7 @@ describe('SharedConfigProfileStore', async () => {
                 {
                     kinds: [ProfileKind.Unknown],
                     name: 'subsettings',
-                    settings: {
-                        region: undefined,
-                    },
+                    settings: {},
                 },
             ],
             ssoSessions: [

server/aws-lsp-identity/src/language-server/profiles/sharedConfigProfileStore.ts

@@ -67,8 +67,6 @@ export class SharedConfigProfileStore implements ProfileStore {
                     // If the profile does not match any profile type, mark it as an unknown profile
                     if (profile.kinds.length === 0) {
                         profile.kinds.push(ProfileKind.Unknown)
-                        // Dummy field to avoid deleting profile when loading and saving 0 changes to the profile
-                        profile.settings!['region'] = settings['region']
                     }
                     result.profiles.push(profile)
                     break