Skip to content

Commit 641a6ed

Browse files
authored
Python, Java, Javascript: Revert Health Imaging updates (#7648)
* Revert "[Java,C++,Python,JavaScript]: Updating example codes in HealthImaging Service (#7598)" This reverts commit be8209c. * Revert "[Python] HealthImage: Adding Param comment for import_config (#7602)" This reverts commit 32d0a18.
1 parent 309de24 commit 641a6ed

File tree

5 files changed

+40
-104
lines changed

5 files changed

+40
-104
lines changed

cpp/example_code/medical-imaging/start_dicom_import_job.cpp

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@
2929
\param outputBucketName: The name of the S3 bucket for the output.
3030
\param outputDirectory: The directory in the S3 bucket to store the output.
3131
\param roleArn: The ARN of the IAM role with permissions for the import.
32-
\param importConfigJson: The import configuration JSON string (optional).
3332
\param importJobId: A string to receive the import job ID.
3433
\param clientConfig: Aws client configuration.
3534
\return bool: Function succeeded.
@@ -38,7 +37,6 @@ bool AwsDoc::Medical_Imaging::startDICOMImportJob(
3837
const Aws::String &dataStoreID, const Aws::String &inputBucketName,
3938
const Aws::String &inputDirectory, const Aws::String &outputBucketName,
4039
const Aws::String &outputDirectory, const Aws::String &roleArn,
41-
const Aws::String &importConfigJson,
4240
Aws::String &importJobId,
4341
const Aws::Client::ClientConfiguration &clientConfig) {
4442
Aws::MedicalImaging::MedicalImagingClient medicalImagingClient(clientConfig);
@@ -50,20 +48,8 @@ bool AwsDoc::Medical_Imaging::startDICOMImportJob(
5048
startDICOMImportJobRequest.SetInputS3Uri(inputURI);
5149
startDICOMImportJobRequest.SetOutputS3Uri(outputURI);
5250

53-
if (!importConfigJson.empty()) {
54-
Aws::Utils::Json::JsonValue jsonValue(importConfigJson);
55-
if (jsonValue.WasParseSuccessful()) {
56-
startDICOMImportJobRequest.SetImportConfiguration(
57-
Aws::MedicalImaging::Model::ImportConfiguration(jsonValue));
58-
}
59-
else {
60-
std::cerr << "Failed to parse import configuration JSON" << std::endl;
61-
return false;
62-
}
63-
}
64-
65-
Aws::MedicalImaging::Model::StartDICOMImportJobOutcome startDICOMImportJobOutcome =
66-
medicalImagingClient.StartDICOMImportJob(startDICOMImportJobRequest);
51+
Aws::MedicalImaging::Model::StartDICOMImportJobOutcome startDICOMImportJobOutcome = medicalImagingClient.StartDICOMImportJob(
52+
startDICOMImportJobRequest);
6753

6854
if (startDICOMImportJobOutcome.IsSuccess()) {
6955
importJobId = startDICOMImportJobOutcome.GetResult().GetJobId();

javascriptv3/example_code/medical-imaging/actions/start-dicom-import-job.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,25 +13,13 @@ import { medicalImagingClient } from "../libs/medicalImagingClient.js";
1313
* @param {string} dataAccessRoleArn - The Amazon Resource Name (ARN) of the role that grants permission.
1414
* @param {string} inputS3Uri - The URI of the S3 bucket containing the input files.
1515
* @param {string} outputS3Uri - The URI of the S3 bucket where the output files are stored.
16-
* @param {Object} importConfiguration - The configuration for digital pathology import.
1716
*/
1817
export const startDicomImportJob = async (
1918
jobName = "test-1",
2019
datastoreId = "12345678901234567890123456789012",
2120
dataAccessRoleArn = "arn:aws:iam::xxxxxxxxxxxx:role/ImportJobDataAccessRole",
2221
inputS3Uri = "s3://medical-imaging-dicom-input/dicom_input/",
2322
outputS3Uri = "s3://medical-imaging-output/job_output/",
24-
importConfiguration = {
25-
digitalPathologyImportConfiguration: {
26-
qualityFactor: 85,
27-
fileMetadataMappings: [
28-
{
29-
imageFilePath: "image.svs",
30-
metadataFilePath: "metadata.json",
31-
},
32-
],
33-
},
34-
},
3523
) => {
3624
const response = await medicalImagingClient.send(
3725
new StartDICOMImportJobCommand({
@@ -40,7 +28,6 @@ export const startDicomImportJob = async (
4028
dataAccessRoleArn: dataAccessRoleArn,
4129
inputS3Uri: inputS3Uri,
4230
outputS3Uri: outputS3Uri,
43-
importConfiguration: importConfiguration,
4431
}),
4532
);
4633
console.log(response);

javav2/example_code/medicalimaging/src/main/java/com/example/medicalimaging/StartDicomImportJob.java

Lines changed: 21 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -64,53 +64,28 @@ public static void main(String[] args) {
6464

6565
// snippet-start:[medicalimaging.java2.start_dicom_import_job.main]
6666
public static String startDicomImportJob(MedicalImagingClient medicalImagingClient,
67-
String jobName,
68-
String datastoreId,
69-
String dataAccessRoleArn,
70-
String inputS3Uri,
71-
String outputS3Uri,
72-
String importConfigJson) {
73-
74-
try {
75-
software.amazon.awssdk.utils.json.JsonNode jsonNode =
76-
software.amazon.awssdk.utils.json.JsonFactory.jsonParser().parse(importConfigJson);
77-
78-
ImportConfiguration importConfiguration = ImportConfiguration.builder()
79-
.digitalPathologyImportConfiguration(
80-
DigitalPathologyImportConfiguration.builder()
81-
.qualityFactor(jsonNode.get("digitalPathologyImportConfiguration")
82-
.get("qualityFactor").asInt())
83-
.fileMetadataMappings(
84-
jsonNode.get("digitalPathologyImportConfiguration")
85-
.get("fileMetadataMappings")
86-
.elements()
87-
.map(mapping -> FileMetadataMapping.builder()
88-
.imageFilePath(mapping.get("imageFilePath").asString())
89-
.metadataFilePath(mapping.get("metadataFilePath").asString())
90-
.build())
91-
.collect(java.util.stream.Collectors.toList())
92-
)
93-
.build()
94-
)
67+
String jobName,
68+
String datastoreId,
69+
String dataAccessRoleArn,
70+
String inputS3Uri,
71+
String outputS3Uri) {
72+
73+
try {
74+
StartDicomImportJobRequest startDicomImportJobRequest = StartDicomImportJobRequest.builder()
75+
.jobName(jobName)
76+
.datastoreId(datastoreId)
77+
.dataAccessRoleArn(dataAccessRoleArn)
78+
.inputS3Uri(inputS3Uri)
79+
.outputS3Uri(outputS3Uri)
9580
.build();
96-
97-
StartDicomImportJobRequest startDicomImportJobRequest = StartDicomImportJobRequest.builder()
98-
.jobName(jobName)
99-
.datastoreId(datastoreId)
100-
.dataAccessRoleArn(dataAccessRoleArn)
101-
.inputS3Uri(inputS3Uri)
102-
.outputS3Uri(outputS3Uri)
103-
.importConfiguration(importConfiguration)
104-
.build();
105-
106-
StartDicomImportJobResponse response = medicalImagingClient.startDICOMImportJob(startDicomImportJobRequest);
107-
return response.jobId();
108-
} catch (MedicalImagingException e) {
109-
System.err.println(e.awsErrorDetails().errorMessage());
110-
System.exit(1);
111-
}
112-
113-
return "";
81+
StartDicomImportJobResponse response = medicalImagingClient.startDICOMImportJob(startDicomImportJobRequest);
82+
return response.jobId();
83+
} catch (MedicalImagingException e) {
84+
System.err.println(e.awsErrorDetails().errorMessage());
85+
System.exit(1);
11486
}
87+
88+
return "";
89+
}
11590
// snippet-end:[medicalimaging.java2.start_dicom_import_job.main]
11691
}

python/example_code/medical-imaging/README.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -43,24 +43,24 @@ python -m pip install -r requirements.txt
4343

4444
Code excerpts that show you how to call individual service functions.
4545

46-
- [CopyImageSet](medical_imaging_basics.py#L418)
46+
- [CopyImageSet](medical_imaging_basics.py#L417)
4747
- [CreateDatastore](medical_imaging_basics.py#L31)
4848
- [DeleteDatastore](medical_imaging_basics.py#L104)
49-
- [DeleteImageSet](medical_imaging_basics.py#L490)
50-
- [GetDICOMImportJob](medical_imaging_basics.py#L159)
49+
- [DeleteImageSet](medical_imaging_basics.py#L489)
50+
- [GetDICOMImportJob](medical_imaging_basics.py#L158)
5151
- [GetDatastore](medical_imaging_basics.py#L54)
52-
- [GetImageFrame](medical_imaging_basics.py#L319)
53-
- [GetImageSet](medical_imaging_basics.py#L242)
54-
- [GetImageSetMetadata](medical_imaging_basics.py#L275)
55-
- [ListDICOMImportJobs](medical_imaging_basics.py#L184)
52+
- [GetImageFrame](medical_imaging_basics.py#L318)
53+
- [GetImageSet](medical_imaging_basics.py#L241)
54+
- [GetImageSetMetadata](medical_imaging_basics.py#L274)
55+
- [ListDICOMImportJobs](medical_imaging_basics.py#L183)
5656
- [ListDatastores](medical_imaging_basics.py#L79)
57-
- [ListImageSetVersions](medical_imaging_basics.py#L351)
58-
- [ListTagsForResource](medical_imaging_basics.py#L557)
59-
- [SearchImageSets](medical_imaging_basics.py#L212)
57+
- [ListImageSetVersions](medical_imaging_basics.py#L350)
58+
- [ListTagsForResource](medical_imaging_basics.py#L556)
59+
- [SearchImageSets](medical_imaging_basics.py#L211)
6060
- [StartDICOMImportJob](medical_imaging_basics.py#L124)
61-
- [TagResource](medical_imaging_basics.py#L515)
62-
- [UntagResource](medical_imaging_basics.py#L535)
63-
- [UpdateImageSetMetadata](medical_imaging_basics.py#L382)
61+
- [TagResource](medical_imaging_basics.py#L514)
62+
- [UntagResource](medical_imaging_basics.py#L534)
63+
- [UpdateImageSetMetadata](medical_imaging_basics.py#L381)
6464

6565
### Scenarios
6666

python/example_code/medical-imaging/medical_imaging_basics.py

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ def delete_datastore(self, datastore_id):
123123

124124
# snippet-start:[python.example_code.medical-imaging.StartDICOMImportJob]
125125
def start_dicom_import_job(
126-
self, job_name, datastore_id, role_arn, input_s3_uri, output_s3_uri, import_configuration
127-
):
126+
self, job_name, datastore_id, role_arn, input_s3_uri, output_s3_uri
127+
):
128128
"""
129129
Start a DICOM import job.
130130
@@ -133,7 +133,6 @@ def start_dicom_import_job(
133133
:param role_arn: The Amazon Resource Name (ARN) of the role to use for the job.
134134
:param input_s3_uri: The S3 bucket input prefix path containing the DICOM files.
135135
:param output_s3_uri: The S3 bucket output prefix path for the result.
136-
:param importConfiguration: The configuration for digital pathology import.
137136
:return: The job ID.
138137
"""
139138
try:
@@ -143,7 +142,6 @@ def start_dicom_import_job(
143142
dataAccessRoleArn=role_arn,
144143
inputS3Uri=input_s3_uri,
145144
outputS3Uri=output_s3_uri,
146-
importConfiguration=import_configuration
147145
)
148146
except ClientError as err:
149147
logger.error(
@@ -154,6 +152,7 @@ def start_dicom_import_job(
154152
raise
155153
else:
156154
return job["jobId"]
155+
157156
# snippet-end:[python.example_code.medical-imaging.StartDICOMImportJob]
158157

159158
# snippet-start:[python.example_code.medical-imaging.GetDICOMImportJob]
@@ -710,19 +709,8 @@ def usage_demo(self, source_s3_uri, dest_s3_uri, data_access_role_arn):
710709
print(f"datastores : {datastores}")
711710

712711
job_name = "python_usage_demo_job"
713-
import_configuration = {
714-
"digitalPathologyImportConfiguration": {
715-
"qualityFactor": 85,
716-
"fileMetadataMappings": [
717-
{
718-
"imageFilePath": "image.svs",
719-
"metadataFilePath": "metadata.json"
720-
}
721-
]
722-
}
723-
}
724712
job_id = self.start_dicom_import_job(
725-
job_name, data_store_id, data_access_role_arn, source_s3_uri, dest_s3_uri, import_configuration
713+
job_name, data_store_id, data_access_role_arn, source_s3_uri, dest_s3_uri
726714
)
727715
print(f"Started import job with id: {job_id}")
728716

0 commit comments

Comments
 (0)