Skip to content

Conversation

@arnewouters
Copy link
Contributor

@arnewouters arnewouters commented Nov 26, 2025

Fixes

Summary

Changes

Please provide a summary of what's being changed

The Origin header syntax is <scheme>://<hostname>:<port> so the logic we use for removing the port number by splitting on : and taking the first element is wrong.

  • Fix parsing according to the Origin header syntax
  • Update tests to also be in line with the correct Origin header syntax

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have reviewed the contributing guidelines
  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Is this a breaking change? (Y/N)

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (b27ba88) to head (526251d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1851      +/-   ##
==========================================
+ Coverage   90.42%   90.51%   +0.09%     
==========================================
  Files         851      745     -106     
  Lines       63315    56411    -6904     
  Branches    10253     9357     -896     
==========================================
- Hits        57252    51060    -6192     
+ Misses       3772     3238     -534     
+ Partials     2291     2113     -178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arnewouters arnewouters marked this pull request as ready for review November 26, 2025 19:41
@arnewouters arnewouters added this pull request to the merge queue Nov 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 28, 2025
@scottschreckengaust scottschreckengaust added the ready-for-merge Folks believe this is ready to merge label Nov 28, 2025
@arnewouters arnewouters added this pull request to the merge queue Nov 28, 2025
Merged via the queue into awslabs:main with commit 52e2022 Nov 28, 2025
150 checks passed
@arnewouters arnewouters deleted the fix/origin-parsing branch November 28, 2025 16:01
@github-project-automation github-project-automation bot moved this from To triage to Done in awslabs/mcp Project Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge Folks believe this is ready to merge

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants