Skip to content

Commit 1a11c97

Browse files
committed
fix: fix documented number of cores in a10s
A10s has 8 cores, not 4
1 parent 21e2192 commit 1a11c97

File tree

4 files changed

+20
-20
lines changed

4 files changed

+20
-20
lines changed

packages/commands/measure/src/__tests__/__snapshots__/measure.test.tsx.snap

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Average CPU usage
2424
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much processing power, so it's important to check CPU usage.
2525
Depending on the device, this value can go up to
2626
100% x number of cores
27-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
27+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
2828
High CPU Usage
2929
0.5 s
3030
Impacted threads:
@@ -862,7 +862,7 @@ exports[`flashlight measure interactive it displays measures: Web app with measu
862862
<code>
863863
100% x number of cores
864864
</code>
865-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
865+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
866866
</div>
867867
</div>
868868
</div>
@@ -3825,7 +3825,7 @@ Average CPU usage
38253825
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much processing power, so it's important to check CPU usage.
38263826
Depending on the device, this value can go up to
38273827
100% x number of cores
3828-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
3828+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
38293829
High CPU Usage
38303830
-
38313831
Impacted threads:
@@ -4226,7 +4226,7 @@ exports[`flashlight measure interactive it displays measures: Web app with no me
42264226
<code>
42274227
100% x number of cores
42284228
</code>
4229-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
4229+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
42304230
</div>
42314231
</div>
42324232
</div>

packages/core/web-reporter-ui/__tests__/__snapshots__/ReporterView.test.tsx.snap

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ Average CPU usage
6565
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much processing power, so it's important to check CPU usage.
6666
Depending on the device, this value can go up to
6767
100% x number of cores
68-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
68+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
6969
Min Max Range:
7070

7171
41
@@ -242,7 +242,7 @@ Average CPU usage
242242
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much processing power, so it's important to check CPU usage.
243243
Depending on the device, this value can go up to
244244
100% x number of cores
245-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
245+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
246246
Min Max Range:
247247

248248
21
@@ -2221,7 +2221,7 @@ exports[`<ReporterView /> renders the comparison view 2`] = `
22212221
<code>
22222222
100% x number of cores
22232223
</code>
2224-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
2224+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
22252225
</div>
22262226
<div
22272227
class="h-2"
@@ -2897,7 +2897,7 @@ exports[`<ReporterView /> renders the comparison view 2`] = `
28972897
<code>
28982898
100% x number of cores
28992899
</code>
2900-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
2900+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
29012901
</div>
29022902
<div
29032903
class="h-2"
@@ -14031,7 +14031,7 @@ Average CPU usage
1403114031
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much processing power, so it's important to check CPU usage.
1403214032
Depending on the device, this value can go up to
1403314033
100% x number of cores
14034-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
14034+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
1403514035
High CPU Usage
1403614036
3.5 s
1403714037
Impacted threads:
@@ -14072,7 +14072,7 @@ Average CPU usage
1407214072
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much processing power, so it's important to check CPU usage.
1407314073
Depending on the device, this value can go up to
1407414074
100% x number of cores
14075-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
14075+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
1407614076
High CPU Usage
1407714077
1 s
1407814078
(-71%)
@@ -15591,7 +15591,7 @@ exports[`<ReporterView /> renders the comparison view 4`] = `
1559115591
<code>
1559215592
100% x number of cores
1559315593
</code>
15594-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
15594+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
1559515595
</div>
1559615596
</div>
1559715597
</div>
@@ -16024,7 +16024,7 @@ exports[`<ReporterView /> renders the comparison view 4`] = `
1602416024
<code>
1602516025
100% x number of cores
1602616026
</code>
16027-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
16027+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
1602816028
</div>
1602916029
</div>
1603016030
</div>
@@ -22040,7 +22040,7 @@ Average CPU usage
2204022040
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much processing power, so it's important to check CPU usage.
2204122041
Depending on the device, this value can go up to
2204222042
100% x number of cores
22043-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
22043+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
2204422044
Min Max Range:
2204522045

2204622046
70
@@ -22248,7 +22248,7 @@ Average CPU usage
2224822248
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much processing power, so it's important to check CPU usage.
2224922249
Depending on the device, this value can go up to
2225022250
100% x number of cores
22251-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
22251+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
2225222252
Min Max Range:
2225322253

2225422254
82
@@ -23830,7 +23830,7 @@ exports[`<ReporterView /> renders the comparison view with videos 2`] = `
2383023830
<code>
2383123831
100% x number of cores
2383223832
</code>
23833-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
23833+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
2383423834
</div>
2383523835
<div
2383623836
class="h-2"
@@ -24549,7 +24549,7 @@ exports[`<ReporterView /> renders the comparison view with videos 2`] = `
2454924549
<code>
2455024550
100% x number of cores
2455124551
</code>
24552-
. For instance, a Samsung A10s has 4 cores, so the max value would be 400%.
24552+
. For instance, a Samsung A10s has 8 cores, so the max value would be 400%.
2455324553
</div>
2455424554
<div
2455524555
class="h-2"

packages/core/web-reporter-ui/src/sections/ReportSummary/Explanations.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const AverageCPUUsageExplanation = () => (
2929
An app might run at high frame rates, such as 60 FPS or higher, but might be using too much
3030
processing power, so it&apos;s important to check CPU usage.
3131
<br /> Depending on the device, this value can go up to <code>100% x number of cores</code>. For
32-
instance, a Samsung A10s has 4 cores, so the max value would be 400%.
32+
instance, a Samsung A10s has 8 cores, so the max value would be 800%.
3333
</>
3434
);
3535

website/static/examples/flashlist/report.js

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)