Skip to content

Commit 77239f9

Browse files
footballencartabaopham
authored andcommitted
Updated to run with Laravel 5.8 and fix tests (#194)
1 parent d080e78 commit 77239f9

File tree

10 files changed

+13
-12
lines changed

10 files changed

+13
-12
lines changed

.travis.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,9 @@ stages:
77
- test
88

99
php:
10-
- '5.6'
11-
- '7.0'
1210
- '7.1'
1311
- '7.2'
12+
- '7.3'
1413

1514
before_script:
1615
- java -Djava.library.path=./DynamoDBLocal_lib -jar dynamodb_local/DynamoDBLocal.jar --port 3000 &

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -608,3 +608,4 @@ Author and Contributors
608608
* [Alexander Ward](https://github.com/cthos)
609609
* [Quang Ngo](https://github.com/vanquang9387)
610610
* [David Higgins](https://github.com/zoul0813)
611+
* [Damon Williams](https://github.com/footballencarta)

composer.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"keywords": ["laravel", "dynamodb", "aws"],
55
"require": {
66
"aws/aws-sdk-php": "^3.0.0",
7-
"illuminate/support": "5.1.* || 5.2.* || 5.3.* || 5.4.* || 5.5.* || 5.6.* || 5.7.*",
8-
"illuminate/database": "5.1.* || 5.2.* || 5.3.* || 5.4.* || 5.5.* || 5.6.* || 5.7.*"
7+
"illuminate/support": "5.1.* || 5.2.* || 5.3.* || 5.4.* || 5.5.* || 5.6.* || 5.7.* || 5.8.*",
8+
"illuminate/database": "5.1.* || 5.2.* || 5.3.* || 5.4.* || 5.5.* || 5.6.* || 5.7.* || 5.8.*"
99
},
1010
"license": "MIT",
1111
"authors": [
@@ -19,7 +19,6 @@
1919
"BaoPham\\DynamoDb\\": "src/"
2020
}
2121
},
22-
"minimum-stability": "dev",
2322
"require-dev": {
2423
"orchestra/testbench": "~3.0"
2524
},

src/RawDynamoDbQuery.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,8 @@ public function count()
136136
* For backward compatibility, previously we use array to represent the raw query
137137
*
138138
* @var array
139+
*
140+
* @return array
139141
*/
140142
private function internal()
141143
{

tests/DynamoDb/DynamoDbManagerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ class DynamoDbManagerTest extends DynamoDbTestCase
2020
*/
2121
protected $mockedClient;
2222

23-
public function setUp()
23+
public function setUp(): void
2424
{
2525
parent::setUp();
2626

tests/DynamoDbClientServiceTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
*/
1414
class DynamoDbClientServiceTest extends TestCase
1515
{
16-
public function setUp()
16+
public function setUp(): void
1717
{
1818
parent::setUp();
1919

@@ -75,7 +75,7 @@ public function testUnsetDynamoDbClientService()
7575
/**
7676
* Make sure we are not leaving any values set on the DynamoDbModel
7777
*/
78-
public function tearDown()
78+
public function tearDown(): void
7979
{
8080
parent::tearDown();
8181

tests/DynamoDbModelTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ abstract class DynamoDbModelTest extends DynamoDbTestCase
2121
*/
2222
protected $marshaler;
2323

24-
public function setUp()
24+
public function setUp(): void
2525
{
2626
parent::setUp();
2727

tests/DynamoDbTestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
*/
1313
abstract class DynamoDbTestCase extends TestCase
1414
{
15-
public function setUp()
15+
public function setUp(): void
1616
{
1717
parent::setUp();
1818

tests/Parsers/ConditionExpressionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class ConditionExpressionTest extends TestCase
2626
*/
2727
private $values;
2828

29-
public function setUp()
29+
public function setUp(): void
3030
{
3131
parent::setUp();
3232
$this->names = new ExpressionAttributeNames();

tests/Parsers/UpdateExpressionTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class UpdateExpressionTest extends TestCase
1818
*/
1919
private $names;
2020

21-
public function setUp()
21+
public function setUp(): void
2222
{
2323
parent::setUp();
2424
$this->names = new ExpressionAttributeNames();

0 commit comments

Comments
 (0)