Double quote to prevent globbing and word splitting

Author: pgrange

bash_unit

@@ -30,9 +30,9 @@ fail() {
   local stdout=$2
   local stderr=$3
 
-  notify_test_failed $__bash_unit_current_test__ "$message"
-  [[ ! -z $stdout ]] && [ -s $stdout ] && notify_stdout < $stdout
-  [[ ! -z $stderr ]] && [ -s $stderr ] && notify_stderr < $stderr
+  notify_test_failed "$__bash_unit_current_test__" "$message"
+  [[ ! -z $stdout ]] && [ -s "$stdout" ] && notify_stdout < "$stdout"
+  [[ ! -z $stderr ]] && [ -s "$stderr" ] && notify_stderr < "$stderr"
 
   stacktrace | notify_stack
   exit 1
@@ -76,13 +76,13 @@ _assert_expression() {
   (
     local stdout=$(mktemp)
     local stderr=$(mktemp)
-    trap "rm  -f $stdout $stderr" EXIT
+    trap "rm  -f \"$stdout\" \"$stderr\"" EXIT
 
     local status
-    eval "($assertion)" >$stdout 2>$stderr && status=$? || status=$?
-    if ! eval $condition
+    eval "($assertion)" >"$stdout" 2>"$stderr" && status=$? || status=$?
+    if ! eval "$condition"
     then
-      fail "$(eval echo $message)" $stdout $stderr
+      fail "$(eval echo $message)" "$stdout" "$stderr"
     fi
   ) || exit $?
 }
@@ -132,7 +132,7 @@ stacktrace() {
 
 run_test_suite() {
   local failure=0
-  for test in $(set | grep  -E '^test.* ()' | grep -E "$test_pattern" | sed -e 's: .*::')
+  for test in $(set | grep  -E '^test.* \(\)' | grep -E "$test_pattern" | sed -e 's: .*::')
   do
     (
       local status=0
@@ -204,7 +204,7 @@ pretty_failure() {
 
 text_format() {
   notify_suite_starting() {
-    test_file="$1"
+    local test_file="$1"
     echo "Running tests in $test_file"
   }
   notify_test_starting() {
@@ -234,7 +234,7 @@ text_format() {
 
 tap_format() {
   notify_suite_starting() {
-    test_file="$1"
+    local test_file="$1"
     echo "# Running tests in $test_file"
   }
   notify_test_starting() {

tests/test_bash_unit.sh

@@ -224,7 +224,7 @@ test_one_test_should_stop_when_assert_fails() {
 }
 
 test_bash_unit_changes_cwd_to_current_test_file_directory() {
-  assert "ls ../tests/$(basename $BASH_SOURCE)" \
+  assert "ls ../tests/$(basename "$BASH_SOURCE")" \
     "bash_unit should change current working directory to match the directory of the currenlty running test"
 }
 

tests/test_doc.sh

@@ -62,5 +62,5 @@ function _next_quote_section() {
   '
 }
 
-cd $(dirname $0)
+cd "$(dirname "$0")"
 prepare_tests