Do not force PIC linkage in external tests

For reasons unknown, rules_go linkages are happening with PIC forced,
but abseil is not.

We can re-enable external tests on LLVM 15 by explicitly saying `-nopie`
to the linker. However, abseil builds will complain about the flag.

Author: Siddhartha Bagaria

tests/MODULE.bazel

@@ -93,14 +93,6 @@ llvm.toolchain(
 )
 use_repo(llvm, "llvm_toolchain_with_urls")
 
-# # This is the latest version of LLVM that seems to work with rules_go; later
-# # versions cause the tests to crash.
-llvm.toolchain(
-    name = "llvm_toolchain_14_0_0",
-    llvm_version = "14.0.0",
-)
-use_repo(llvm, "llvm_toolchain_14_0_0")
-
 # # This is the last known LLVM version with zlib support in ld.lld. Without zlib
 # # support, if the installed gcc toolchain has compressed sections in its object
 # # files, then ld.lld won't be able to process them. Example is archlinux docker

tests/WORKSPACE

@@ -66,13 +66,6 @@ llvm_toolchain(
     },
 )
 
-# This is the latest version of LLVM that seems to work with rules_go; later
-# versions cause the tests to crash.
-llvm_toolchain(
-    name = "llvm_toolchain_14_0_0",
-    llvm_version = "14.0.0",
-)
-
 # This is the last known LLVM version with zlib support in ld.lld. Without zlib
 # support, if the installed gcc toolchain has compressed sections in its object
 # files, then ld.lld won't be able to process them. Example is archlinux docker

tests/scripts/run_external_tests.sh

@@ -31,11 +31,8 @@ fi
 
 test_args=(
   "${common_test_args[@]}"
-  # Fix LLVM version to be 14.0.0 because that's the last known version with
-  # which the tests in rules_go pass.
-  "--extra_toolchains=@llvm_toolchain_14_0_0//:all"
-  # Options needed for LLVM 15 when we switch to using it for these tests
-  #"--copt=-Wno-deprecated-builtins" # https://github.com/abseil/abseil-cpp/issues/1201
+  "--linkopt=-nopie"                # https://github.com/grailbio/bazel-toolchain/issues/183
+  "--copt=-Wno-deprecated-builtins" # https://github.com/abseil/abseil-cpp/issues/1201
 )
 
 # We exclude the following targets: