Migrate aswb/base to aswb_library (#7575)

and address new lint warnings.

Bug: n/a
Test: n/a
Change-Id: I668e3ea346023ad6230da64adf844e64b4fb0f95

AOSP: 33cbd443efce966170d1c33b9a4bf9e24d805cf2

Co-authored-by: Googler <[email protected]>

Author: sellophane

base/src/com/google/idea/blaze/base/async/process/ExternalTask.java

@@ -61,12 +61,12 @@ default Future<Integer> runAsync(BlazeScope... scopes) {
 
   /** A builder for an external task */
   class Builder {
-    @VisibleForTesting public final ImmutableList.Builder<String> command = ImmutableList.builder();
+    public final ImmutableList.Builder<String> command = ImmutableList.builder();
     File workingDirectory;
     final Map<String, String> environmentVariables = Maps.newHashMap();
-    @VisibleForTesting @Nullable public BlazeContext context;
-    @VisibleForTesting @Nullable public OutputStream stdout;
-    @VisibleForTesting @Nullable public OutputStream stderr;
+    @Nullable public BlazeContext context;
+    @Nullable public OutputStream stdout;
+    @Nullable public OutputStream stderr;
     @Nullable BlazeCommand blazeCommand;
     boolean redirectErrorStream = false;
     boolean ignoreExitCode = false;

base/src/com/google/idea/blaze/base/async/process/ExternalTaskProvider.java

@@ -24,7 +24,6 @@
  * Constructs an {@link ExternalTask} from a builder instance. This indirection exists to allow easy
  * redirection in blaze-invoking integration tests.
  */
-@VisibleForTesting
 public interface ExternalTaskProvider {
 
   static ExternalTaskProvider getInstance() {

base/src/com/google/idea/blaze/base/bazel/BazelVersion.java

@@ -66,7 +66,6 @@ int getBugfix() {
     return bugfix;
   }
 
-  @VisibleForTesting
   public static BazelVersion parseVersion(@Nullable String string) {
     // treat all unknown / development versions as the very latest version
     if (string == null) {

base/src/com/google/idea/blaze/base/command/BlazeFlags.java

@@ -108,7 +108,6 @@ public static List<String> blazeFlags(
   public static final String ADB = "--adb";
 
   // We add this to every single BlazeCommand instance. It's for tracking usage.
-  @VisibleForTesting
   public static String getToolTagFlag() {
     String platformPrefix = PlatformUtils.getPlatformPrefix();
 

base/src/com/google/idea/blaze/base/command/buildresult/BuildResult.java

@@ -15,6 +15,7 @@
  */
 package com.google.idea.blaze.base.command.buildresult;
 
+import java.util.Locale;
 import java.util.Objects;
 
 /** The result of a blaze operation */
@@ -42,7 +43,7 @@ private static Status fromExitCode(int exitCode) {
 
     @Override
     public String toString() {
-      return name().toLowerCase();
+      return name().toLowerCase(Locale.ROOT);
     }
   }
 

base/src/com/google/idea/blaze/base/dependencies/ExternalFileProjectManagementHelper.java

@@ -60,6 +60,7 @@
 import java.nio.file.Path;
 import java.util.HashSet;
 import java.util.List;
+import java.util.Locale;
 import java.util.Set;
 import java.util.concurrent.ExecutionException;
 import java.util.function.Consumer;
@@ -104,7 +105,7 @@ public Key<EditorNotificationPanel> getKey() {
   /** Whether the editor notification should be shown for this file type. */
   private static boolean supportedFileType(File file) {
     LanguageClass language =
-        LanguageClass.fromExtension(FileUtilRt.getExtension(file.getName()).toLowerCase());
+        LanguageClass.fromExtension(FileUtilRt.getExtension(file.getName()).toLowerCase(Locale.ROOT));
     if (language != null && !LanguageSupport.languagesSupportedByCurrentIde().contains(language)) {
       return false;
     }

base/src/com/google/idea/blaze/base/filecache/RemoteOutputsCache.java

@@ -66,6 +66,7 @@
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
@@ -185,7 +186,7 @@ private void updateCache(
           RemoteArtifactPrefetcher.getInstance()
               .downloadArtifacts(
                   /* projectName= */ project.getName(), /* outputArtifacts= */ artifactsToDownload);
-      logger.info(String.format("Prefetching %d output artifacts", artifactsToDownload.size()));
+      logger.info(String.format(Locale.ROOT, "Prefetching %d output artifacts", artifactsToDownload.size()));
       FutureUtil.waitForFuture(context, downloadArtifactsFuture)
           .timed("PrefetchRemoteOutput", EventType.Prefetching)
           .withProgressMessage("Prefetching output artifacts...")

base/src/com/google/idea/blaze/base/ideinfo/ArtifactLocation.java

@@ -37,6 +37,7 @@ private ArtifactLocation(
     this.isExternal = isExternal;
   }
 
+  @SuppressWarnings("NoInterning")
   public static ArtifactLocation fromProto(Common.ArtifactLocation proto) {
     return ProjectDataInterner.intern(
         new ArtifactLocation(

base/src/com/google/idea/blaze/base/io/FileOperationProvider.java

@@ -91,6 +91,7 @@ public Path createTempFile(
     return Files.createTempFile(tempDirectory, prefix, suffix, attributes);
   }
 
+  @SuppressWarnings("NoNioFilesCopy")
   public File copy(File source, File target, CopyOption... options) throws IOException {
     return Files.copy(source.toPath(), target.toPath(), options).toFile();
   }

base/src/com/google/idea/blaze/base/issueparser/BlazeIssueParser.java

@@ -439,8 +439,8 @@ protected IssueOutput createIssue(Matcher matcher) {
    */
   static class GenericErrorParser extends SingleLineParser {
 
-    // Match either specific blacklisted patterns we don't want, or the generic error message we do.
-    // Then throw away the blacklisted matches later.
+    // Match either specific patterns we don't want, or the generic error message we do.
+    // Then throw away the matches patterns later.
     private static final ImmutableList<String> COMMON_PATTERNS = ImmutableList.of(
             "(//.+?: Exit [0-9]+\\.)",
             "(.*: Process exited with status [0-9]+\\.)",