Skip to content

Commit 830c00e

Browse files
committed
Fix the rest of the tests, hopefully
1 parent 864ea30 commit 830c00e

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

.bazelci/presubmit.yml

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -96,15 +96,20 @@ rules_bzlmod: &rules_bzlmod
9696
<<: *rules
9797
resource_rules_bzlmod: &resource_rules_bzlmod
9898
name: "Resource Rules Bzlmod"
99+
build_targets:
100+
- "//test/rules/resources/..."
101+
test_targets:
102+
- "//test/rules/resources/..."
99103
build_flags:
100104
<<: *rules_flags
101105
? "--enable_bzlmod"
102106
? "--enable_workspace=false"
107+
? "--//rules/flags:manifest_merge_order=legacy"
103108
test_flags:
104109
<<: *rules_flags
105110
? "--enable_bzlmod"
106111
? "--enable_workspace=false"
107-
<<: *resource_rules
112+
? "--//rules/flags:manifest_merge_order=legacy"
108113

109114
tasks:
110115
tools:
@@ -115,20 +120,18 @@ tasks:
115120
platform: ${{ platform }}
116121
bazel: ${{ bazel }}
117122
<<: *rules
118-
# TODO(#397): Resource tests need some more debugging.
119-
## resource_rules:
120-
## platform: ${{ platform }}
121-
## bazel: ${{ bazel }}
122-
## <<: *resource_rules
123+
resource_rules:
124+
platform: ${{ platform }}
125+
bazel: ${{ bazel }}
126+
<<: *resource_rules
123127
tools_bzlmod:
124128
platform: ${{ platform }}
125129
bazel: ${{ bazel }}
126130
<<: *tools_bzlmod
127-
# TODO(#397): Resource tests need some more debugging.
128-
## resource_rules_bzlmod:
129-
## platform: ${{ platform }}
130-
## bazel: ${{ bazel }}
131-
## <<: *resource_rules_bzlmod
131+
resource_rules_bzlmod:
132+
platform: ${{ platform }}
133+
bazel: ${{ bazel }}
134+
<<: *resource_rules_bzlmod
132135
rules_bzlmod:
133136
platform: ${{ platform }}
134137
bazel: ${{ bazel }}

test/rules/resources/test.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ def _starlark_process_test_impl(ctx):
178178
)
179179
runfiles = r_java.runtime_output_jars + [ctx.executable._r_class_check]
180180
java = ctx.attr._host_javabase[java_common.JavaRuntimeInfo]
181-
args["java"] = java.java_executable_exec_path
181+
args["java"] = java.java_executable_runfiles_path
182182

183183
elif ctx.attr.expected_r_class_fields:
184184
fail("Expected a R.java file but none was generated")

0 commit comments

Comments
 (0)